Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FutureGroup to dart:async #6626

Closed
munificent opened this issue Nov 8, 2012 · 8 comments
Closed

Add FutureGroup to dart:async #6626

munificent opened this issue Nov 8, 2012 · 8 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-not-planned Closed as we don't intend to take action on the reported issue type-enhancement A request for a change that isn't a bug

Comments

@munificent
Copy link
Member

Web components has a nice FutureGroup class that lets you wait on a dynamically modifiable set of futures. It ends up coming in handy in a few places (like test.dart). Consider adding it to dart:core?

https://github.com/dart-lang/dart-web-components/blob/master/lib/src/utils.dart#L90

@justinfagnani
Copy link
Contributor

I'm using web_ui's FutureGroup in buildtool. It's definitely handy, and we now have a suitable library to put it in in dart:async.


cc @jmesserly.

@DartBot
Copy link

DartBot commented Jan 28, 2013

This comment was originally written by munificentbob...@gmail.com


+1! We copy/pasted this into Pub to use it there too. Would be nice if it was just in dart:async.

@DartBot
Copy link

DartBot commented Jan 29, 2013

This comment was originally written by @seaneagan


Often you have an Iterable<E> each of whose elements are mapped to a Future<T>, so it would be nice if it were FutureGroup<T>. And now that Future no longer exposes a "value" property, it would make more sense for FutureGroup.future to be a Future<List<T>> instead of a Future<List<Future<T>>>. Also, a FutureGroup.from constructor might be nice.

@jmesserly
Copy link

cc @sigmundch.
Set owner to @jmesserly.
Removed Type-Defect label.
Added Type-Enhancement label.
Changed the title to: "Add FutureGroup to dart:async".

@sigmundch
Copy link
Member

We now have another copy in polymer :)

Florian/Lasse - what are your thoughts on adding this type to dart:async?

I'd be happy to create a patch for you, but I wanted to make sure you like the idea first.


cc @jmesserly.
cc @floitschG.
cc @lrhn.
Removed the owner.

@munificent
Copy link
Member Author

It's also in scheduled_test and test.py. :)

@floitschG
Copy link
Contributor

I like it, but it should not be in dart:async, but in a package.


Added NotPlanned label.

@justinfagnani
Copy link
Contributor

It's already available in quiver.async: http://google.github.io/quiver-dart/docs/quiver.async/FutureGroup.html

@munificent munificent added Type-Enhancement area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-not-planned Closed as we don't intend to take action on the reported issue labels Nov 18, 2013
nex3 added a commit to dart-lang/async that referenced this issue Jun 13, 2015
This class has been copied around in various forms for ages; see for
example dart-lang/sdk#6626. This is more or less a full rewrite with
tests added.

R=lrn@google.com

Review URL: https://codereview.chromium.org//1179053003.
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-not-planned Closed as we don't intend to take action on the reported issue type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

7 participants