Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec allows static getters and setters in interfaces #679

Closed
DartBot opened this issue Dec 3, 2011 · 5 comments
Closed

Spec allows static getters and setters in interfaces #679

DartBot opened this issue Dec 3, 2011 · 5 comments
Assignees
Labels
area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). closed-not-planned Closed as we don't intend to take action on the reported issue
Milestone

Comments

@DartBot
Copy link

DartBot commented Dec 3, 2011

This issue was originally filed by alexei.kaigorodov...@gmail.com


8 Interfaces
interfaceMemberDefinition:
...
getterSignature ‘;’ |
setterSignature ‘;’ |
...

getterSignature:
  static? returnType? get identifier formalParameterList;
setterSignature:
  static? returnType? set identifier formalParameterList;

That is, static getters and setters are allowed in interfaces.
On the other hand, both dartc and dart issue compiler error when static getters or setters encountered, which looks reasonable. Either spec or implementation needs to be fixed.

@DartBot
Copy link
Author

DartBot commented Dec 5, 2011

This comment was originally written by drfibonacci@google.com


Added Area-Language, Triaged labels.

@gbracha
Copy link
Contributor

gbracha commented Dec 8, 2011

Set owner to @gbracha.
Added Accepted label.

@anders-sandholm
Copy link
Contributor

Added this to the M1 milestone.

@gbracha
Copy link
Contributor

gbracha commented May 18, 2012

Marked this as being blocked by #2975.

@gbracha
Copy link
Contributor

gbracha commented Jul 10, 2012

Moot point. Interface declarations are going away.


Added WontFix label.
Marked this as being blocked by #2975.
Unmarked this as being blocked by #2975.

@DartBot DartBot added Type-Defect area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). labels Jul 10, 2012
@DartBot DartBot added this to the M1 milestone Jul 10, 2012
@kevmoo kevmoo added closed-not-planned Closed as we don't intend to take action on the reported issue and removed resolution-wont_fix labels Mar 1, 2016
copybara-service bot pushed a commit that referenced this issue Jun 16, 2022
…ions)

https://dart.googlesource.com/protobuf/+log/3105588b8e51..3149f6f2d323

2022-06-16 omersa@google.com Use `dart compile js` instead of `dart2js` in bench builders
2022-06-16 omersa@google.com Remove `ProtobufContainer` superclass of `CodeGenerator` (#647)
2022-06-16 omersa@google.com Remove redundant reserved names (#679)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-protobuf-dart-sdk
Please CC dart-ecosystem-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dart Protobuf Support: https://github.com/dart-lang/protobuf/issues
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: dart-ecosystem-gardener@grotations.appspotmail.com
Change-Id: I89162783f5edcea85ed56ee2258b71ac390bca7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248761
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). closed-not-planned Closed as we don't intend to take action on the reported issue
Projects
None yet
Development

No branches or pull requests

4 participants