Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize Windows drive letters to uppercase for analysis #32133

Closed
wants to merge 1 commit into from

Conversation

DanTup
Copy link
Collaborator

@DanTup DanTup commented Feb 13, 2018

This fixes #32095, however I'm currently unable to get the tests running locally. I'll continue to work on that, but I'm hoping that creating a PR runs all the tests on CI so we should at least get to see if this (legitimately) broke anything in the meantime?

Turns out this also fixes #32042! I can't run the latest analyzer code against a version of the SDK that the flutter_tools is happy with, however I rolled my analyzer code back to 2.0-dev.22 and repro'd this error, then applied the same changes from this PR to that version, and the errors went away.

Turns out to also fix #28895!

@bwilkerson

@DanTup
Copy link
Collaborator Author

DanTup commented Feb 13, 2018

Oh, looks like there's no CI build for the PR... I'll continue working on getting the tests running locally before this is merged!

@DanTup
Copy link
Collaborator Author

DanTup commented Feb 13, 2018

I was running the wrong tests here (analysis_server, but the change is in analyzer). Analyzer tests all pass both before/after this change:

02:46 +22943: All tests passed!

@bwilkerson
Copy link
Member

See https://dart-review.googlesource.com/c/sdk/+/40720 for review comments.

@DanTup
Copy link
Collaborator Author

DanTup commented Feb 13, 2018

@bwilkerson

you can either click the button labeled "CQ Dry Run"

Where should that appear? I can't see it but don't know if that might be permission related (I have logged in as danny @ tuppeny...) or because you've already clicked it?

Should I be using Gerrit to raise reviews for things? If so, are there any notes on the process for raising a review once a PR is sent?

@bwilkerson
Copy link
Member

I'll send you an e-mail where we can have a process discussion. Seems more appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants