Fixed some links #36927
Closed
Fixed some links #36927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old link was a 404; also this is not exactly the same content, the link is working again
Old link is no longer accessible Style adapted from https://github.com/dart-lang/sdk/blob/master/sdk/lib/_internal/js_runtime/lib/math_patch.dart#L130 and https://github.com/dart-lang/sdk/blob/master/runtime/lib/math.cc#L122 and https://github.com/dart-lang/sdk/blob/master/pkg/dev_compiler/tool/input_sdk/patch/math_patch.dart#L143
Old link was a 404; website is no longer accessible Wikipedia says that this has been renamed https://en.wikipedia.org/wiki/The_Computer_Language_Benchmarks_Game This seems to be the new location of the website
dartbug-links must not end with a '/'
dartbug-links must not end with a '/' removed '.' at the end of the line as other regression tests don't have a dot at this position
dartbug-links must not end with a '/'
dartbug-links must not end with a '/'
dartbug-links must not end with a '/' added empty line as other regression tests have one there too
import should happen after regression-description (see other tests)
dartbug-links must not end with a '/'
dartbug-links must not end with a '/'
dartbug-links must not be TLS-encrypted
Remove link as repo has changed location, is archived and doesn't show issues
Couldn't find a new location or archived version of this information
Added missing '/'
line-break made link not working
link contained two ':'
|
Wow! Awesome! CC @athomas there is some magic to get this going through https://dart-review.googlesource.com/q/status:open – stay tuned! |
|
Thanks much @LorenzNickel for this PR, and sorry that it got stuck! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed some links and some other minor flaws.
I also found the following outdated links, which I didn't fix:
While doing all this I also noticed that these tests contain a lot of other inconsistencies in their comments and the location of the import-statements (I only fixed one which was not link-related), could be target of another PR.