No need set hostname when hostname is a IP Address. #52707
Conversation
|
Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at: https://dart-review.googlesource.com/c/sdk/+/309620 Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR). |
|
/cc @brianquinlan |
|
Assigning a reviewer here to remove this from our triage queue (the review itself should happen on the gerrit CL). |
|
Hey @mount33 I made a comment at https://dart-review.googlesource.com/c/sdk/+/309620 |
Just make a request to https://1.1.1.1, you will reproduce the problem. import 'dart:convert';
import 'dart:io';
void main() async {
final req = await HttpClient().getUrl(Uri.parse('https://1.1.1.1/'));
final resp = await req.close();
final content = await resp.transform(utf8.decoder).join();
print(content);
} |
|
https://dart-review.googlesource.com/c/sdk/+/309620 has been updated with the latest commits from this pull request. |
1 similar comment
|
https://dart-review.googlesource.com/c/sdk/+/309620 has been updated with the latest commits from this pull request. |
|
@brianquinlan ping? should this PR be closed? |
|
Hey @mount33, I ran the script that you suggested with Dart 3.1.0 (and Dart 3.0 and Dart 2.9) and got the same output as curl i.e. What platform are you using, maybe the effect is platform-specific? |
@brianquinlan I previously tested on Windows 11 x64 with Flutter SDK 3.7.11. Perhaps it has already been fixed. I apologize for wasting your valuable time. |
|
I tested this with Dart 3.1 on Windows and could not repro. No need to apologize! Thank you so much for the effort! |
When hostname is IP Address SSL_set_tlsext_host_name cause TLS handshake failed.
Bug #49183