Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print styles need work #149

Closed
kwalrath opened this issue Sep 27, 2016 · 8 comments
Closed

print styles need work #149

kwalrath opened this issue Sep 27, 2016 · 8 comments
Labels
co.beginner Community opportunity to make a small change to documentation co.help-wanted Community opportunity to help documentation infra.design Relates to the design of docs.Dart.dev

Comments

@kwalrath
Copy link
Contributor

When you print out a page, you see all kinds of stuff that you shouldn't—headers, footers, and more.

@kwalrath kwalrath added the co.help-wanted Community opportunity to help documentation label Sep 27, 2016
@kwalrath kwalrath self-assigned this Sep 28, 2016
@kwalrath
Copy link
Contributor Author

Partially fixed by #150. I should apply these fixes to webdev.dartlang.org, as well.

Some other print format issues I noticed:

  • Notes should have a box around them, but don't. They just look indented for no reason (especially in notes where there's no bold title to lead off... we really should make a point of doing that). For an example, see https://www.dartlang.org/tools/pub/cmd.
  • In Canary, at least, the printout often has blank pages at the end. For example, https://www.dartlang.org/tools/pub/cmd has 3 pages of content followed by 4 blank pages.

@kwalrath kwalrath added the infra.design Relates to the design of docs.Dart.dev label Sep 28, 2016
@kwalrath kwalrath changed the title print styles are awful print styles need work Oct 5, 2016
@kwalrath kwalrath removed their assignment Oct 11, 2016
@Sfshaza
Copy link

Sfshaza commented Oct 12, 2016

Another issue. Highlighted text in code blocks doesn't display.

@kwalrath
Copy link
Contributor Author

kwalrath commented Jan 4, 2017

Another issue: local URLs print (in parens) after their link, but external URLs don't. If we were to differentiate, the opposite should be true. I'm inclined to just underline the link text and NOT provide the URL in the printed version. The external link icon could probably be dropped, too.

@kwalrath kwalrath self-assigned this Jan 7, 2017
@kwalrath
Copy link
Contributor Author

kwalrath commented Jan 7, 2017

I'm working on some fixes... should have a PR soon.

@kwalrath
Copy link
Contributor Author

kwalrath commented Jul 14, 2017

All the print issues might be fixed... but I'm not sure. I'd love for someone else to take a look and see what we could do to improve.

@kwalrath kwalrath added the co.beginner Community opportunity to make a small change to documentation label Jul 14, 2017
@Sfshaza
Copy link

Sfshaza commented Jul 14, 2017

I've looked at several pages on www.dartlang. I brought up the print panel, and viewed the preview there - I didn't actually print.

  • There are still no boxes around notes. (same as reported)
  • Local URLs still display, but you only see the link icon for external links. (same as reported)

Overall, I think the output looks pretty good!

@Sfshaza
Copy link

Sfshaza commented Jul 14, 2017

Oh, the table in the Get Started page doesn't look that great, but I doubt this is a page that will be printed much.

@kwalrath kwalrath removed their assignment Jul 14, 2017
kwalrath pushed a commit that referenced this issue Nov 13, 2017
@kwalrath
Copy link
Contributor Author

There might still be a few ways we can improve print styles (maybe code highlighting?), but we can file individual bugs for those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co.beginner Community opportunity to make a small change to documentation co.help-wanted Community opportunity to help documentation infra.design Relates to the design of docs.Dart.dev
Projects
None yet
Development

No branches or pull requests

2 participants