-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
print styles need work #149
Comments
Partially fixed by #150. I should apply these fixes to webdev.dartlang.org, as well. Some other print format issues I noticed:
|
Another issue. Highlighted text in code blocks doesn't display. |
Another issue: local URLs print (in parens) after their link, but external URLs don't. If we were to differentiate, the opposite should be true. I'm inclined to just underline the link text and NOT provide the URL in the printed version. The external link icon could probably be dropped, too. |
I'm working on some fixes... should have a PR soon. |
All the print issues might be fixed... but I'm not sure. I'd love for someone else to take a look and see what we could do to improve. |
I've looked at several pages on www.dartlang. I brought up the print panel, and viewed the preview there - I didn't actually print.
Overall, I think the output looks pretty good! |
Oh, the table in the Get Started page doesn't look that great, but I doubt this is a page that will be printed much. |
There might still be a few ways we can improve print styles (maybe code highlighting?), but we can file individual bugs for those. |
When you print out a page, you see all kinds of stuff that you shouldn't—headers, footers, and more.
The text was updated successfully, but these errors were encountered: