Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TODO about explaining that non-required params can be null #3297

Closed
vendz opened this issue Jun 3, 2021 · 4 comments
Closed

Remove TODO about explaining that non-required params can be null #3297

vendz opened this issue Jun 3, 2021 · 4 comments
Labels
a.language Relates to the Dart language tour dev.null-safety Relates to transforming or migrating Dart code to sound null safety e0-minutes Can complete in < 60 minutes of normal, not dedicated, work p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface.

Comments

@vendz
Copy link
Contributor

vendz commented Jun 3, 2021 •
edited

TODO link: https://github.com/dart-lang/site-www/blob/master/null_safety_examples/misc/lib/language_tour/functions.dart#L29
@parlough parlough added e0-minutes Can complete in < 60 minutes of normal, not dedicated, work a.language Relates to the Dart language tour dev.null-safety Relates to transforming or migrating Dart code to sound null safety p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface. labels Jun 3, 2021
@parlough
Copy link
Member

parlough commented Jun 3, 2021

Thanks for opening this issue @vendz ! Taking a look at the language tour, I'm thinking the addition of this tip(https://github.com/dart-lang/site-www/blame/master/src/_guides/language/language-tour.md#L1334) may have addressed this issue. What do you think @kwalrath?

@kwalrath
Copy link
Contributor

kwalrath commented Jun 3, 2021

I think you're right, @parlough. I'm going to close this.

@kwalrath kwalrath closed this as completed Jun 3, 2021
@kwalrath
Copy link
Contributor

kwalrath commented Jun 3, 2021

Reopening because we should remove the TODO. :)

@kwalrath kwalrath reopened this Jun 3, 2021
@kwalrath kwalrath changed the title TODO(miquelbeltran) language-tour.md should explain that non-required params can be null Remove TODO about explaining that non-required params can be null Jun 3, 2021
@vendz
Copy link
Contributor Author

vendz commented Jun 4, 2021

@kwalrath should I remove the todo from file and create a PR

@parlough parlough mentioned this issue Jun 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a.language Relates to the Dart language tour dev.null-safety Relates to transforming or migrating Dart code to sound null safety e0-minutes Can complete in < 60 minutes of normal, not dedicated, work p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kwalrath @parlough @vendz