Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added issue reference to todos #3299

Merged
merged 11 commits into from Jun 4, 2021
Merged

added issue reference to todos #3299

merged 11 commits into from Jun 4, 2021

Conversation

vendz
Copy link
Contributor

@vendz vendz commented Jun 3, 2021

in reference to #2119

@google-cla
Copy link

google-cla bot commented Jun 3, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no Contributor has not signed the Contributor License Agreement label Jun 3, 2021
@vendz
Copy link
Contributor Author

vendz commented Jun 3, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes Contributor has signed the Contributor License Agreement and removed cla: no Contributor has not signed the Contributor License Agreement labels Jun 3, 2021
@vendz
Copy link
Contributor Author

vendz commented Jun 3, 2021

@kwalrath please review my PR

Copy link
Contributor

@kwalrath kwalrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @vendz!

I believe that the test failures are due to line length > 80. Could you break up the lines? While you're at it, you might make these full URLs. Or not. :)

@vendz
Copy link
Contributor Author

vendz commented Jun 4, 2021

@kwalrath I have made changes to the TODO line so if you could review my PR now

@vendz
Copy link
Contributor Author

vendz commented Jun 4, 2021

@parlough i have made the changes you requested in this PR itself so if you could review it

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions, feel free to ignore them if desired.

Thanks again!

Comment on lines 29 to 30
// TODO(miquelbeltran) language-tour.md should explain that
// non-required params can be null (#3297)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this one instead like mentioned in #3297 and include Fixes #3297 again?

Suggested change
// TODO(miquelbeltran) language-tour.md should explain that
// non-required params can be null (#3297)

Comment on lines 4 to 5
// TODO(chalin): I believe that handleError's test argument should be declared (#3298)
// as follows, but it isn't: {bool Function(dynamic error) test}.
Copy link
Member

@parlough parlough Jun 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you place it after the whole comment and instead put a link to the issue so its easier to access when navigating the source?

Suggested change
// TODO(chalin): I believe that handleError's test argument should be declared (#3298)
// as follows, but it isn't: {bool Function(dynamic error) test}.
// TODO(chalin): I believe that handleError's test argument should be declared
// as follows, but it isn't: {bool Function(dynamic error) test}.
// (https://github.com/dart-lang/site-www/issues/3298)

@vendz
Copy link
Contributor Author

vendz commented Jun 4, 2021

@parlough made the changes you requested.

@parlough
Copy link
Member

parlough commented Jun 4, 2021

@vendz Thanks for all the work, looks good to me! I'm running the checks and if they're all green, I'll merge these changes :)

@parlough parlough merged commit c95f9bb into dart-lang:master Jun 4, 2021
@parlough
Copy link
Member

parlough commented Jun 4, 2021

All tests were green after I removed the extra whitespace and the changes have been committed to the main branch(c95f9bb). Thanks again @vendz and good work and communication around your first contribution on site-www :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants