Add issue references to TODOs and removed outdated ones(#3299)

* Update browser_test.dart * added issue reference to todo * added issue reference to todo * added issue reference to todo * referencing issues to TODO * fixes #3294 * fixes #3297 * Update stream_interface.dart * Update browser_test.dart * Apply suggestions from code review Co-authored-by: Parker Lougheed <parlough@gmail.com>
dart-lang · Jun 4, 2021 · c95f9bb · c95f9bb
1 parent 0aa9a03
commit c95f9bb
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 2 deletions.
diff --git a/null_safety_examples/misc/lib/language_tour/functions.dart b/null_safety_examples/misc/lib/language_tour/functions.dart
@@ -26,7 +26,6 @@ void miscDeclAnalyzedButNotTested() {
   }
 
   {
-    // TODO(miquelbeltran) language-tour.md should explain that non-required params can be null
     // #docregion specify-named-parameters
     /// Sets the [bold] and [hidden] flags ...
     void enableFlags({bool? bold, bool? hidden}) {/*...*/}

diff --git a/null_safety_examples/misc/lib/tutorial/stream_interface.dart b/null_safety_examples/misc/lib/tutorial/stream_interface.dart
@@ -3,6 +3,7 @@ import 'dart:async';
 
 // TODO(chalin): I believe that handleError's test argument should be declared
 // as follows, but it isn't: {bool Function(dynamic error) test}.
+// (https://github.com/dart-lang/site-www/issues/3298)
 
 abstract class MyStream<T> implements Stream<T> {
   // #docregion main-stream-members

diff --git a/null_safety_examples/misc/test/language_tour/browser_test.dart b/null_safety_examples/misc/test/language_tour/browser_test.dart
@@ -14,6 +14,7 @@ void main() {
     void reverseText(MouseEvent e) {}
 
     // TODO(miquelbeltran) Maybe ! would be better here
+    // (https://github.com/dart-lang/site-www/issues/3295)
     // #docregion simple-web-main-function
     void main() {
       querySelector('#sample_text_id')

diff --git a/null_safety_examples/misc/test/language_tour/generics_test.dart b/null_safety_examples/misc/test/language_tour/generics_test.dart
@@ -23,7 +23,6 @@ void main() {
 
   test('generic-collections', () {
     void _test() {
-      // TODO(miquelbeltran) language-tour.md should be updated, List<String> cannot be used with null-safety
       // #docregion generic-collections
       var names = <String>[];
       names.addAll(['Seth', 'Kathy', 'Lars']);