Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim down and reorganize examples code #416

Closed
chalin opened this issue Nov 2, 2017 · 3 comments
Closed

Trim down and reorganize examples code #416

chalin opened this issue Nov 2, 2017 · 3 comments
Labels
fix.examples Adds or changes example test.general Relates to unit, integration, perf testing

Comments

@chalin
Copy link
Contributor

chalin commented Nov 2, 2017

@kwalrath - A few questions about the code that came from the up-and-running repo:

  • Some of the examples contain much more code than what is used in the tour code excerpts. Could we trim this down (before we start writing tests for all the code excerpts - Code excerpts should be auto-updated and tested #407)?
  • Is it necessary to keep the current example subfolder structure? Some very small code excerpts could be combined (of course, provided that there is a meaningful grouping).
  • Each example (except for those under reference) has its own main() etc. Our main goals is to test the code excerpts, not necessarily run them. So in some cases, the extra code used to run the excerpt could be dropped in favor of having tests instead.

Thoughts?
@chalin chalin added fix.examples Adds or changes example test.general Relates to unit, integration, perf testing labels Nov 2, 2017
@kwalrath
Copy link
Contributor

kwalrath commented Nov 6, 2017

Feel free to do anything that'll make the code easier to deal with and test. You have carte blanche.

@kwalrath
Copy link
Contributor

kwalrath commented Nov 6, 2017

Actually, one caveat... We might want to convert some/most of the examples to be DartPads. Those might need to be complete examples (or easily convertible to complete examples).

@chalin chalin mentioned this issue Nov 9, 2017
Closed
chalin added a commit that referenced this issue Nov 13, 2017
@chalin
Language tour example tests + Travis test job setup
df01dd2 
- See `examples/README.md` for details. Essentially, `examples` is now a Dart package from which all sample tests will be run.
- A few tests are run in chrome, so Travis setup has been adapted so that chrome is installed and configured to run tests.
- Also added highlights to some code excerpts (more will be added later).

**Note**: Eventually the "original" example sources (`examples/language_tour ` and `examples/library_tour `) will be deleted, once we are sure that all relevant parts (including some that are only in Gists) have been integrated into the new package.

Contributes to #407 and #416.
chalin added a commit that referenced this issue Nov 13, 2017
@chalin
Language tour example tests + Travis test job setup
4d11f7f 
- See `examples/README.md` for details. Essentially, `examples` is now a Dart package from which all sample tests will be run.
- A few tests are run in chrome, so Travis setup has been adapted so that chrome is installed and configured to run tests.
- Also added highlights to some code excerpts (more will be added later).

**Note**: Eventually the "original" example sources (`examples/language_tour ` and `examples/library_tour `) will be deleted, once we are sure that all relevant parts (including some that are only in Gists) have been integrated into the new package.

Contributes to #407 and #416.
chalin added a commit that referenced this issue Nov 13, 2017
@chalin
Language tour example tests + Travis test job setup
a0e9fb6 
- See `examples/README.md` for details. Essentially, `examples` is now a Dart package from which all sample tests will be run.
- A few tests are run in chrome, so Travis setup has been adapted so that chrome is installed and configured to run tests.
- Also added highlights to some code excerpts (more will be added later).

**Note**: Eventually the "original" example sources (`examples/language_tour ` and `examples/library_tour `) will be deleted, once we are sure that all relevant parts (including some that are only in Gists) have been integrated into the new package.

Contributes to #407 and #416.
chalin added a commit that referenced this issue Nov 13, 2017
@chalin
Language tour example tests + Travis test job setup
851f97b 
- See `examples/README.md` for details. Essentially, `examples` is now a Dart package from which all sample tests will be run.
- A few tests are run in chrome, so Travis setup has been adapted so that chrome is installed and configured to run tests.
- Also added highlights to some code excerpts (more will be added later).

**Note**: Eventually the "original" example sources (`examples/language_tour ` and `examples/library_tour `) will be deleted, once we are sure that all relevant parts (including some that are only in Gists) have been integrated into the new package.

Contributes to #407 and #416.
@chalin chalin mentioned this issue Nov 13, 2017
Merged
chalin added a commit that referenced this issue Nov 14, 2017
@chalin
Language tour example tests + Travis test job setup
0bf913e 
- See `examples/README.md` for details. Essentially, `examples` is now a Dart package from which all sample tests will be run.
- A few tests are run in chrome, so Travis setup has been adapted so that chrome is installed and configured to run tests.
- Also added highlights to some code excerpts (more will be added later).

**Note**: Eventually the "original" example sources (`examples/language_tour ` and `examples/library_tour `) will be deleted, once we are sure that all relevant parts (including some that are only in Gists) have been integrated into the new package.

Contributes to #407 and #416.
chalin added a commit that referenced this issue Nov 15, 2017
@chalin
Language tour example tests + Travis test job setup (#427)
a8b8ac9 
* Language tour example tests + Travis test job setup

- See `examples/README.md` for details. Essentially, `examples` is now a Dart package from which all sample tests will be run.
- A few tests are run in chrome, so Travis setup has been adapted so that chrome is installed and configured to run tests.
- Also added highlights to some code excerpts (more will be added later).

**Note**: Eventually the "original" example sources (`examples/language_tour ` and `examples/library_tour `) will be deleted, once we are sure that all relevant parts (including some that are only in Gists) have been integrated into the new package.

Contributes to #407 and #416.

* Post-review edits
chalin added a commit to chalin/site-www that referenced this issue Nov 20, 2017
@chalin
Library tour example tests, up to but excluding dart:html
bce8c72 
Contributes to dart-lang#407 and dart-lang#416.
@chalin chalin mentioned this issue Nov 20, 2017
Merged
chalin added a commit that referenced this issue Nov 21, 2017
@chalin
Library tour example tests, up to but excluding dart:html (#440)
783590c 
* Library tour example tests, up to but excluding dart:html

Contributes to #407 and #416.

* Post-review edits
chalin added a commit to chalin/site-www that referenced this issue Nov 21, 2017
@chalin
Library tour example tests from dart:html onwards
c1451ce 
Contributes to dart-lang#407 and dart-lang#416.

Continuation of dart-lang#440
chalin added a commit to chalin/site-www that referenced this issue Nov 22, 2017
@chalin
Library tour example tests from dart:html onwards
8fc1d7a 
Contributes to dart-lang#407 and dart-lang#416.

Continuation of dart-lang#440
chalin added a commit to chalin/site-www that referenced this issue Nov 22, 2017
@chalin
Library tour example tests from dart:html onwards
ad8e76b 
Contributes to dart-lang#407 and dart-lang#416.

Continuation of dart-lang#440
@chalin chalin mentioned this issue Nov 22, 2017
Merged
chalin added a commit that referenced this issue Nov 22, 2017
@chalin
Library tour example tests from dart:html (#443)
792c517 
Contributes to #407 and #416.

Continuation of #440
chalin added a commit to chalin/site-www that referenced this issue Nov 23, 2017
@chalin
Library tour example tests for dart:io
3d98378 
Contributes to dart-lang#407 and dart-lang#416.

Continuation of dart-lang#443
@chalin chalin mentioned this issue Nov 23, 2017
Merged
chalin added a commit to chalin/site-www that referenced this issue Nov 23, 2017
@chalin
Library tour example tests for dart:io
6da2adc 
Contributes to dart-lang#407 and dart-lang#416.

Continuation of dart-lang#443
chalin added a commit that referenced this issue Nov 24, 2017
@chalin
Library tour example tests for dart:io, dart:convert, dart:mirrors (#445
e8a4c90 
)

* Library tour example tests for dart:io

Contributes to #407 and #416.

Continuation of #443

* Tests for dart:convert

* dart:mirrors

* Post-review edits
@chalin
Copy link
Contributor Author

chalin commented Dec 12, 2017

Completed via #445, #443, #440, ... .

@chalin chalin closed this as completed Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fix.examples Adds or changes example test.general Relates to unit, integration, perf testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kwalrath @chalin