-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library tour example tests for dart:html #443
Conversation
Contributes to dart-lang#407 and dart-lang#416. Continuation of dart-lang#440
hosted on an origin that is different from the origin of the app. If you | ||
need to access resources that live on a different web server, you need | ||
to either use a technique called JSONP or enable CORS headers on the | ||
remote resources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section is about "Using HTTP resources with HttpRequest", so I've simplified the examples by dropping use of JSON (since JSON is covered in the dart:convert
section further below in this tour.
method: 'HEAD', | ||
); | ||
if (req.status == 200) { | ||
// Successful URL access... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, this example has been simplified, focusing on the HttpRequest.request()
call. For variability, I've shown a HEAD method call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool, and thanks for updating the examples as well.
} | ||
}); | ||
|
||
group('xxxx', () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be here? Should the name be a bit too descriptive? Just checking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, no; the 'xxxx' entries are just templates I use when copy-pasting new code excerpts. They'll be removed in the next round (and by the time we're done with the Library Tour they should be gone for good).
Contributes to dart-lang#407 and dart-lang#416. Continuation of dart-lang#443
Contributes to dart-lang#407 and dart-lang#416. Continuation of dart-lang#443
Contributes to #407 and #416.
Continuation of #440