Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library tour example tests for dart:html #443

Merged
merged 1 commit into from
Nov 22, 2017

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Nov 22, 2017

Contributes to #407 and #416.

Continuation of #440

@chalin chalin added fix.examples Adds or changes example a.libraries Relating to the Dart standard libraries. test.general Relates to unit, integration, perf testing labels Nov 22, 2017
@chalin chalin added this to the 1.24 milestone Nov 22, 2017
@chalin chalin requested a review from filiph November 22, 2017 21:29
@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Nov 22, 2017
hosted on an origin that is different from the origin of the app. If you
need to access resources that live on a different web server, you need
to either use a technique called JSONP or enable CORS headers on the
remote resources.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is about "Using HTTP resources with HttpRequest", so I've simplified the examples by dropping use of JSON (since JSON is covered in the dart:convert section further below in this tour.

method: 'HEAD',
);
if (req.status == 200) {
// Successful URL access...
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, this example has been simplified, focusing on the HttpRequest.request() call. For variability, I've shown a HEAD method call.

Copy link
Contributor

@filiph filiph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, and thanks for updating the examples as well.

}
});

group('xxxx', () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be here? Should the name be a bit too descriptive? Just checking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, no; the 'xxxx' entries are just templates I use when copy-pasting new code excerpts. They'll be removed in the next round (and by the time we're done with the Library Tour they should be gone for good).

@chalin chalin merged commit 792c517 into dart-lang:master Nov 22, 2017
@chalin chalin deleted the chalin-lib-tour-1121 branch November 22, 2017 22:31
@chalin chalin changed the title Library tour example tests from dart:html Library tour example tests for dart:html Nov 23, 2017
chalin added a commit to chalin/site-www that referenced this pull request Nov 23, 2017
chalin added a commit to chalin/site-www that referenced this pull request Nov 23, 2017
chalin added a commit that referenced this pull request Nov 24, 2017
)

* Library tour example tests for dart:io

Contributes to #407 and #416.

Continuation of #443

* Tests for dart:convert

* dart:mirrors

* Post-review edits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a.libraries Relating to the Dart standard libraries. cla: yes Contributor has signed the Contributor License Agreement fix.examples Adds or changes example test.general Relates to unit, integration, perf testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants