Run Dart 2.3.2 dartfmt

[mit-mit]

No description provided.

[sfshaza2]

Of course, this PR primarily looks fine. The only possible issue, is that we often run dartfmt with a maximum line length of 70 (or so) to avoid having the example code wrap when displayed on the site. Are we sure that this was not going on here?

Otherwise, LGTM. :)

[sfshaza2]

Assuming that the line length wasn't intentionally shortened (as mentioned in my other comment), LGTM.

[mit-mit]

I ran it with the default line length. Is that not what we usual do?

[sfshaza2]

You'd have to check with Kathy for recent info, but we used to run it with a default line length of 70, otherwise the code often wrapped in those code blocks. But things may have changed.

…

On Sat, Jun 15, 2019 at 12:01 AM Michael Thomsen ***@***.***> wrote: I ran it with the default line length. Is that not what we usual do? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1683?email_source=notifications&email_token=AKS4PKK7NJJT6RZHV2PLXGDP2SHTDA5CNFSM4HYHTAO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXYR6TI#issuecomment-502341453>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKS4PKNYUYCXX6TJMBW5J4DP2SHTDANCNFSM4HYHTAOQ> .

[johnpryan]

Is this still necessary now that we've upgraded to 2.4?

[mit-mit]

Yes, see: https://travis-ci.org/dart-lang/site-www/jobs/551280797

But I think we can wait until @kwalrath is back to answer the line length question

[sfshaza2]

Agreed. This isn't urgent..

…

On Thu, Jun 27, 2019 at 1:47 PM Michael Thomsen ***@***.***> wrote: Yes, see: https://travis-ci.org/dart-lang/site-www/jobs/551280797 But I think we can wait until @kwalrath <https://github.com/kwalrath> is back to answer the line length question — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1683?email_source=notifications&email_token=AKS4PKNM3HDMHCQJQB3UEH3P4URMNA5CNFSM4HYHTAO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYYKMYA#issuecomment-506504800>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKS4PKJBYMZCT4B5PMG32S3P4URMNANCNFSM4HYHTAOQ> .

[kwalrath]

We don’t run dartfmt directly… instead, we use tool/dartfmt.sh. When I run that, I see only one diff. I’m looking into it now…

[kwalrath]

Only one file needs to change due to dartfmt. I’ve fixed that in #1717.