Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added issue reference to todos #3299

Merged
merged 11 commits into from Jun 4, 2021
1 change: 0 additions & 1 deletion null_safety_examples/misc/lib/language_tour/functions.dart
Expand Up @@ -26,7 +26,6 @@ void miscDeclAnalyzedButNotTested() {
}

{
// TODO(miquelbeltran) language-tour.md should explain that non-required params can be null
// #docregion specify-named-parameters
/// Sets the [bold] and [hidden] flags ...
void enableFlags({bool? bold, bool? hidden}) {/*...*/}
Expand Down
Expand Up @@ -3,6 +3,7 @@ import 'dart:async';

// TODO(chalin): I believe that handleError's test argument should be declared
// as follows, but it isn't: {bool Function(dynamic error) test}.
// (https://github.com/dart-lang/site-www/issues/3298)

abstract class MyStream<T> implements Stream<T> {
// #docregion main-stream-members
Expand Down
Expand Up @@ -14,6 +14,7 @@ void main() {
void reverseText(MouseEvent e) {}

// TODO(miquelbeltran) Maybe ! would be better here
// (https://github.com/dart-lang/site-www/issues/3295)
// #docregion simple-web-main-function
void main() {
querySelector('#sample_text_id')
Expand Down
Expand Up @@ -23,7 +23,6 @@ void main() {

test('generic-collections', () {
void _test() {
// TODO(miquelbeltran) language-tour.md should be updated, List<String> cannot be used with null-safety
// #docregion generic-collections
var names = <String>[];
names.addAll(['Seth', 'Kathy', 'Lars']);
Expand Down