Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds uninstall #5826

Merged
merged 12 commits into from
May 31, 2024
Merged

Adds uninstall #5826

merged 12 commits into from
May 31, 2024

Conversation

atsansone
Copy link
Contributor

@atsansone atsansone commented May 15, 2024

Fixes #3187
Fixes #5829

@atsansone atsansone added the review.copy Awaiting Copy Review label May 15, 2024
@dart-github-bot
Copy link
Collaborator

dart-github-bot commented May 15, 2024

Visit the preview URL for this PR (updated for commit b07cad5):

https://dart-dev--pr5826-fix-3187-dr5c15gn.web.app

@atsansone atsansone force-pushed the fix-3187 branch 2 times, most recently from 19830b6 to e3abdf9 Compare May 15, 2024 22:17
@atsansone

This comment was marked as outdated.

@atsansone atsansone added the st.blocked Issue cannot continue until another action completes label May 16, 2024
@atsansone atsansone removed the st.blocked Issue cannot continue until another action completes label May 17, 2024
@atsansone
Copy link
Contributor Author

@parlough : The change to include worked. Can you approve?

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @atsansone for the new content and clean up here! Will be super useful for users and the improved consistency is nice.

A few comments:

src/_includes/install/windows.md Outdated Show resolved Hide resolved
src/_includes/install/windows.md Outdated Show resolved Hide resolved

1. Launch [Powershell][] with elevated permissions.

1. Use the following command.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Use the following command.
1. Run the following command.

src/_includes/install/windows.md Outdated Show resolved Hide resolved
src/_includes/install/windows.md Outdated Show resolved Hide resolved
src/_includes/install/linux.md Outdated Show resolved Hide resolved
src/_includes/install/linux.md Outdated Show resolved Hide resolved
src/_includes/install/linux.md Outdated Show resolved Hide resolved
src/_includes/install/linux.md Outdated Show resolved Hide resolved
src/content/get-dart/index.md Outdated Show resolved Hide resolved
@parlough parlough assigned atsansone and unassigned parlough and MaryaBelanger May 22, 2024
@parlough parlough added review.await-update Awaiting Updates after Edits and removed review.copy Awaiting Copy Review labels May 22, 2024
Copy link
Contributor Author

@atsansone atsansone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parlough. Thanks! Committing updates now.

src/_includes/install/linux.md Outdated Show resolved Hide resolved
src/_includes/install/windows.md Outdated Show resolved Hide resolved
@atsansone atsansone added review.copy Awaiting Copy Review and removed review.await-update Awaiting Updates after Edits labels May 29, 2024
@atsansone atsansone assigned parlough and unassigned atsansone May 29, 2024
@atsansone atsansone removed the request for review from MaryaBelanger May 29, 2024 20:18
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjustments look good to me, thanks for tackling this long standing enhancement request!

Consider getting a quick copy pass by @MaryaBelanger as well since these pages are high traffic :)

src/_includes/install/windows.md Outdated Show resolved Hide resolved
Co-authored-by: Parker Lougheed <parlough@gmail.com>
@atsansone atsansone added st.RFM.% Ready to Merge but has suggestions and removed review.copy Awaiting Copy Review labels May 31, 2024
@atsansone atsansone assigned atsansone and unassigned MaryaBelanger May 31, 2024
@atsansone atsansone merged commit de510b2 into dart-lang:main May 31, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
st.RFM.% Ready to Merge but has suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix site variable replacement error Add info on how to uninstall Dart
4 participants