Cleanup equality operator to accept any Object rather than just a Sou…

…rceLocation. BUG= R=nweiz@google.com Review URL: https://codereview.chromium.org//881673002
dart-lang · Jan 27, 2015 · 691bc67 · 691bc67
1 parent 4250113
commit 691bc67
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,8 @@
+# 1.0.3
+
+* Cleanup equality operator to accept any Object rather than just a
+  `SourceLocation`.
+
 # 1.0.2
 
 * Avoid unintentionally allocating extra objects for internal `FileSpan`

diff --git a/lib/src/location.dart b/lib/src/location.dart
@@ -77,8 +77,9 @@ class SourceLocation implements Comparable<SourceLocation> {
     return offset - other.offset;
   }
 
-  bool operator ==(SourceLocation other) =>
-      sourceUrl == other.sourceUrl && offset == other.offset;
+  bool operator ==(other) =>
+      other is SourceLocation && sourceUrl == other.sourceUrl &&
+      offset == other.offset;
 
   int get hashCode => sourceUrl.hashCode + offset;
 

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,6 +1,6 @@
 name: source_span
 
-version: 1.0.2
+version: 1.0.3
 author: Dart Team <misc@dartlang.org>
 description: A library for identifying source spans and locations.
 homepage: http://github.com/dart-lang/source_span