-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some retry around launching browsers #1578
Comments
natebosch
added a commit
that referenced
this issue
Mar 16, 2022
Towards #1578 Recursively attempt to launch the browser on the first few timeouts before throwing the ApplicationException.
natebosch
added a commit
that referenced
this issue
Mar 16, 2022
Towards #1578 Recursively attempt to launch the browser on the first few timeouts before throwing the ApplicationException. Restore previous timeout of 30 seconds. The 45 second timeout was mainly to investigate whether extra time would resolve flakes. It didn't seem to help at all and it doesn't seem likely that even more time would help. Go back to 30 seconds to reduce the pain of hitting retries (though it will still be painful).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
test/pkgs/test/lib/src/runner/browser/browser_manager.dart
Lines 129 to 133 in d6329d6
We seem to hit timeouts much more often on github actions.
The text was updated successfully, but these errors were encountered: