Add some retry around browser launching #1676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Towards #1578 Recursively attempt to launch the browser on the first few timeouts before throwing the ApplicationException.
|
I wonder if we should lower the timeout back down too. It had been 30 seconds before and we bumped it to 45 to see if it would reduce flakiness. I don't think it's made any difference - my guess is there is some state we can get in where it will never connect. |
The 45 second timeout was mainly to investigate whether extra time would resolve flakes. It didn't seem to help at all and it doesn't seem likely that even more time would help. Go back to 30 seconds to reduce the pain of hitting retries (though it will still be painful).
jakemac53
reviewed
Mar 16, 2022
jakemac53
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #1578
Recursively attempt to launch the browser on the first few timeouts
before throwing the ApplicationException.