Absolute folder path filters trigger "no test found"

[rrousselGit]

It seems like if dart test folderPath is executed an absolute path instead of a relative path, then dart test will somehow fail to execute the tests

Example:

$ pwd
/Users/remirousselet/dev/invertase/fest/packages/spec_cli

$ dart test .
< works just fine > 

$ dart test /Users/remirousselet/dev/invertase/fest/packages/spec_cli
No tests ran.
No tests were found.

[jakemac53]

This seems to work fine for me on linux, can you clarify what platform you are on or provide any additional info you think might be relevant?

[rrousselGit]

It happened on Mac for me.

I'm not exactly sure what else to say

[jakemac53]

Ok, I don't have a mac to test this on, but I think @natebosch does. Although I would be very surprised if it works on linux but not mac...

[rrousselGit]

Haha, I'm not quite sure either.

In any case, since this was triggered by my custom test renderer, I used a workaround and converted paths to relative ones.

[natebosch]

I can't reproduce this behavior. I'm on mac with the latest stable SDK (2.16.1) and latest test (1.20.1)

I get the same results whether I run with no argument, ., or an absolute path to the directory with or without a trailing /.

[11:08]»  dart test
Building package executable... (7.7s)
Built test:test.
00:04 +394: All tests passed!
[11:08]»  dart test .
00:03 +394: All tests passed!
[11:08]»  dart test /Users/nbosch/repos/stream_transform
00:03 +394: All tests passed!
[11:08]»  dart test /Users/nbosch/repos/stream_transform/
00:03 +394: All tests passed!

[jakemac53]

I am going to close this as not reproducible for now, if you can figure out a way to reproduce it we can take another look

[rrousselGit]

If that helps here's my dart version

Dart SDK version: 2.16.0-144.0.dev (dev) (Thu Dec 30 11:53:00 2021 -0800) on "macos_x64"

on macos 12.2:

Here's a video too:

Screen.Recording.2022-02-14.at.20.28.27.mov

[natebosch]

We must still have some code treating packages as a special directory name. I can repro this if I move my packages into a directory with /packages/ somewhere on the path.

[rrousselGit]

Upgrading Dart to 2.17.0-104.0.dev and test to 1.20.1 (from 1.17.12) changed nothing by the way.

I created a brand new project, and for some reason with that project, absolute paths works.
It seems related to projects with a packages folder from my tests

edit I'm too slow apparently haha

[natebosch]

test/pkgs/test_core/lib/src/runner/loader.dart

Lines 140 to 147 in 5bbe1a8

	Stream<LoadSuite> loadDir(String dir, SuiteConfiguration suiteConfig) {
	return StreamGroup.merge(
	Directory(dir).listSync(recursive: true).map((entry) {
	if (entry is! File ||
	!_config.filename.matches(p.basename(entry.path)) ||
	p.split(entry.path).contains('packages')) {
	return Stream.empty();
	}