Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way for to provide the package_config.json location for a test target #2246

Closed
3 tasks done
kenzieschmoll opened this issue Jun 14, 2024 · 1 comment
Closed
3 tasks done

Comments

@kenzieschmoll
Copy link

kenzieschmoll commented Jun 14, 2024

This is so that VM service clients connected to a test run can perform an evaluation to get the package_config.json file location for the test.

This will require updating every tool that generates a test entrypoint to include this for evaluation

  • package:test
  • flutter tools
  • blaze (g3)
  • build_runner

Action steps:

@natebosch @jakemac53 @bkonyi

natebosch added a commit that referenced this issue Jun 27, 2024
Towards #2246 

This will allow a client of the VM service to evaluate the top level
variable and locate the package config used by the test runner.

Add a public `testBootstapContents` function in `test_compiler.dart`
which centralizes the bootstrap templates. Add an argument for the
package config URI and a `VmTestType` which is either "Vm" or
"Native".

Add the first test case in `test_core`. Add the pub dependency and
override for `package:test`, as well as the mono_repo configuration to
run unit tests. Other tests for `test_core` code is under the `test`
package but should be moved eventually.
kenzieschmoll added a commit to flutter/flutter that referenced this issue Jul 9, 2024
@kenzieschmoll
Copy link
Author

The changes have landed across the Dart SDK, flutter_tools and DevTools. So this is now resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant