Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the main desktop browsers #31

Closed
4 tasks done
nex3 opened this issue Mar 9, 2015 · 2 comments
Closed
4 tasks done

Support the main desktop browsers #31

nex3 opened this issue Mar 9, 2015 · 2 comments
Labels
type-enhancement A request for a change that isn't a bug
Milestone
0.12.0

Comments

@nex3
Copy link
Member

nex3 commented Mar 9, 2015

All the desktop browsers supported by Dart should be supported by the test runner.

  • IE
  • Safari
  • Firefox
  • Chrome
@nex3 nex3 added the type-enhancement A request for a change that isn't a bug label Mar 9, 2015
@nex3 nex3 added this to the 0.12.0 milestone Mar 9, 2015
@nex3 nex3 mentioned this issue Mar 23, 2015
Closed
@zoechi
Copy link

zoechi commented Mar 24, 2015

Can a package like https://github.com/dart-lang/browser_controller used for this?
Support for external launchers might be useful for other scenarios too.

@nex3
Copy link
Member Author

nex3 commented Mar 24, 2015

browser_controller has its own logic for taking control of a browser that would conflict with unittest's logic. It's also unmaintained and would take substantial refactoring to get into a usable state.

Once we have more browser support, I may factor that out into a new package, but I don't think the existing package is a good fit.

nex3 added a commit that referenced this issue Apr 10, 2015
@nex3
Add firefox support.
45c6248 
See #31

R=kevmoo@google.com

Review URL: https://codereview.chromium.org//1070313002
nex3 added a commit that referenced this issue Apr 16, 2015
@nex3
Support running tests on Safari.
98a8dd7 
See #31

R=kevmoo@google.com

Review URL: https://codereview.chromium.org//1062683004
@nex3 nex3 closed this as completed in f169f3d Apr 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
0.12.0
Development

No branches or pull requests
2 participants
@nex3 @zoechi