Add types to Browser implementation url arguments #2096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Towards #2095 Restrict to Uri arguments instead of the looser `dynamic` which in practice allowed Strings (which were correctly formatted) or Uri instances. Take Uri so the format is enforced and the `.toString()` can be trusted. Update (unused in practice) test args from dart-lang.org to dart.dev
jakemac53
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2095
Restrict to Uri arguments instead of the looser
dynamicwhich inpractice allowed Strings (which were correctly formatted) or Uri
instances. Take Uri so the format is enforced and the
.toString()canbe trusted.
Update (unused in practice) test args from dart-lang.org to dart.dev