Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fuzzy arrow warnings since they will become errors before too long. #719

Merged
merged 2 commits into from
Nov 7, 2017

Conversation

munificent
Copy link
Member

@munificent munificent commented Nov 3, 2017

@@ -272,7 +272,7 @@ class BrowserManager {
}

/// The callback for handling messages received from the host page.
void _onMessage(Map message) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this. Is it possible to fix the place where this is used rather than loosen the argument?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer this as well. I'd like to avoid dynamic calls, even though in practice --no-implicit-dynamic isn't really in shape to be enabled yet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to fix the place where this is used rather than loosen the argument?

Done, though it feels a little silly in this case. _onMessage is only called by that one place and Map isn't super precise either.

@@ -272,7 +272,7 @@ class BrowserManager {
}

/// The callback for handling messages received from the host page.
void _onMessage(Map message) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer this as well. I'd like to avoid dynamic calls, even though in practice --no-implicit-dynamic isn't really in shape to be enabled yet.

@munificent munificent merged commit 02a26ac into master Nov 7, 2017
@munificent munificent deleted the 718-fix-fuzzy-arrow branch November 7, 2017 18:37
@nex3 nex3 mentioned this pull request Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants