Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend OAuth2 package to support OpenID connect #304

Closed
DartBot opened this issue Jun 5, 2015 · 8 comments · Fixed by dart-archive/oauth2#47
Closed

Extend OAuth2 package to support OpenID connect #304

DartBot opened this issue Jun 5, 2015 · 8 comments · Fixed by dart-archive/oauth2#47
Labels
contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) P3 A lower priority bug or feature request package:oauth2 type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Jun 5, 2015

Originally opened as dart-lang/sdk#15248

This issue was originally filed by warren.strange...@gmail.com


After thinking this through, I realize this is a fairly major feature request.

The current OAuth2 package (http://pub.dartlang.org/packages/oauth2)

does not support OpenID connect. For example, Openid connect returns a id_token as part of the authorization flow.

A small enhancement would be to extend Credentials.dart to provide the raw value of id_token if it is present.

Ideally, support would be provided for JSON web tokens, signature verification, etc.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/5449880?v=3" align="left" width="48" height="48"hspace="10"> Comment by iposva-google


Added Area-Pkg, Triaged labels.

@DartBot DartBot added type-enhancement A request for a change that isn't a bug P3 A lower priority bug or feature request labels Jun 5, 2015
@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd


Removed Type-Defect, Priority-Unassigned labels.
Added Type-Enhancement, Priority-Low, Pkg-oauth2 labels.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3


Warren, can you provide a link to the spec for the functionality you're describing?


Added NeedsInfo label.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

This comment was originally written by warren.stran...@gmail.com


OIDC spec? http://openid.net/specs/openid-connect-core-1_0.html

i.e. at a high level, how can we make a Dart client consume JWT tokens and participate in OIDC flows.

@nex3
Copy link
Member

nex3 commented Jun 6, 2015

I'd look at a patch that added this, but it's not something I'm planning to add myself.

@nex3 nex3 added the contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) label Jun 6, 2015
@Jeremywhiteley
Copy link

With Google Flutter starting to take off, why can't you add OpenID Connect? It's needed if you want developers to use Google Flutter. Every other mobile framework supports OpenID Connect. This is like buying a new Tesla, but it was delivered with out the batteries.

@nex3
Copy link
Member

nex3 commented May 2, 2018

As I said, contributions here are welcome.

@Matt2012
Copy link

Any updates on this?

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) P3 A lower priority bug or feature request package:oauth2 type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants