Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to exercise collecting coverage from content-shell #568

Closed
evanweible-wf opened this issue Jun 6, 2016 · 2 comments
Closed

Add tests to exercise collecting coverage from content-shell #568

evanweible-wf opened this issue Jun 6, 2016 · 2 comments
Labels
package:coverage type-enhancement A request for a change that isn't a bug

Comments

@evanweible-wf
Copy link

Currently the test suite for this project only exercises collecting coverage from a dart application running on the VM. This does not cover collecting coverage from content-shell.

I bring this up because Travis CI always uses the latest version of Dart, but at times there's an issue with the version of content-shell that it uses for CI builds (see travis-ci/travis-ci#4406). If this package had tests to exercise content-shell coverage collection, those issues would potentially be caught by the CI build.

@cbracken @kevmoo

@cbracken
Copy link
Member

cbracken commented Jun 6, 2016

Agreed -- getting coverage tests against content_shell checked into the repo is definitely valuable.

Think we also need a separate (non-coverage-specific) global canary test that checks the recency and health of content_shell tests on Travis as per that issue.

@cbracken cbracken added the type-enhancement A request for a change that isn't a bug label Jun 6, 2016
ckjeldgaard referenced this issue in ckjeldgaard/currency_converter Jan 11, 2017
@cbracken
Copy link
Member

Since Dartium and Dartium-based content-shell no longer exist, closing this as obsolete.

@mosuem mosuem transferred this issue from dart-archive/coverage Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:coverage type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants