Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics collection for expression evaluation #1006

Open
annagrin opened this issue May 13, 2020 · 0 comments
Open

Add metrics collection for expression evaluation #1006

annagrin opened this issue May 13, 2020 · 0 comments

Comments

@annagrin
Copy link
Contributor

Define, review and implement metrics collection for expression evaluation.

Metrics should include at the very least performance and failure rate.
@annagrin annagrin self-assigned this May 13, 2020
dart-bot pushed a commit to dart-lang/sdk that referenced this issue Sep 22, 2020
Emit module and add logging with timer to expression compilation
1c8020c 
- Emit module before expression compilation to JavaScript so the
  ProgramCompiler has all types available.

- Add logging with ticker to expression compilation in expression
  compilation worker in DDC and in frontend server.

- Remove excessively verbose logging

Related:
dart-lang/webdev#1006
dart-lang/webdev#1106
Change-Id: Ia3a985f2d12d27f0bcc2c5d3923db137070e9cdd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162624
Commit-Queue: Anna Gringauze <annagrin@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@annagrin