Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt pub get/upgrade before running build or serve #8

Closed
wants to merge 2 commits into from

Conversation

nshahan
Copy link
Contributor

@nshahan nshahan commented Jan 22, 2018

No description provided.

@nshahan nshahan requested review from kevmoo and removed request for matanlurey March 19, 2018 23:18
@nshahan
Copy link
Contributor Author

nshahan commented Mar 19, 2018

So the idea I was trying out here was to detect when running build_runner build or build_runner serve failed because of the need for a pub get. If webdev knows we need to run a pub get, it should just do it.

I feel this is needed for the ideal initial workflow:

  • pub global activate webdev
  • webdev create foo
  • cd foo
  • webdev serve

@nshahan
Copy link
Contributor Author

nshahan commented Mar 19, 2018

I'm fine with abandoning this PR now but WDYT?

@kevmoo
Copy link
Member

kevmoo commented Mar 20, 2018

create is out of scope in the short term. Let's just close this PR and revisit later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants