Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password is not respected #2

Closed
seandenigris opened this issue Apr 5, 2018 · 6 comments
Closed

Password is not respected #2

seandenigris opened this issue Apr 5, 2018 · 6 comments

Comments

@seandenigris
Copy link
Contributor

seandenigris commented Apr 5, 2018

There is no setter for a connection's user, and no accessors at all for the user's password. Consequently, the following does not authenticate the user:

conn := IRCConnection new
	user: (IRCUser new
		username: 'Sean DeNigris';
		fullName: 'Sean DeNigris';
		nickname: 'SeanDeNigris';
		password: aString;
		yourself);
	yourself.
	(IRCBasicDisplay connection: conn) openWithSpec.
	conn connect.

Also, I see there is a password instVar for the connection itself. Is that part of the model?

While we're on the subject of passwords, it would be more comfortable to connect via SSL, but changing the port to 6697 or 7000 per the Freenode docs seems to prevent connection.

@darth-cheney
Copy link
Owner

The active User implementation is incomplete. Initially, I had credentials and user info directly on the connection object and I never got around to finishing it.

I will also have to read up on SSL, as I've never implemented anything like that before. Thanks

seandenigris added a commit to seandenigris/pharo-irc that referenced this issue Apr 5, 2018
@seandenigris
Copy link
Contributor Author

Cool, thanks. It looks like a nice little tool. Out of curiosity, why did you fork instead of potentially widening sqIRC to work on both platforms?

@darth-cheney
Copy link
Owner

I am fairly new to Smalltalk, so this was my first "whole project" (as if I even finished!) and I wanted to see if I could do the whole shebang myself. It was only part way into it that I came across squIRC.

I suppose it's still a possibility now, but I can never really get the hang of Squeak because there's too much going on in there

@seandenigris
Copy link
Contributor Author

Ah, okay, not a complaint at all - Multiplatform can get exponentially more complex. Just wondering!

darth-cheney added a commit that referenced this issue Apr 5, 2018
@darth-cheney
Copy link
Owner

Hi @seandenigris -- please check out PR #8. I think I've been able to address both the password and SSL issues. Instructions are in the PR readme. Let me know if it works!

@darth-cheney
Copy link
Owner

Closed by #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants