Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildsys: borrow Makefile improvements from slog #33

Merged
merged 5 commits into from
Jan 14, 2023
Merged

buildsys: borrow Makefile improvements from slog #33

merged 5 commits into from
Jan 14, 2023

Conversation

amery
Copy link
Contributor

@amery amery commented Jan 14, 2023

No description provided.

@amery
build-sys: try setting GOPATH if not in environment already
2819a16 
Signed-off-by: Alejandro Mery <amery@jpi.io>
@amery
build-sys: borrow V=1 and pretty info from Gnocco
3a3ef09 
Signed-off-by: Alejandro Mery <amery@jpi.io>
@amery
build-sys: use $(info ...) instead of echo for comments and simplify …
f061d71 
…the generate call

Signed-off-by: Alejandro Mery <amery@jpi.io>
@amery
build-sys: fix call to revive (arguments)
e7ec174 
Signed-off-by: Alejandro Mery <amery@jpi.io>
@amery
build-sys: improve non-order dependencies handling
47a2286 
Signed-off-by: Alejandro Mery <amery@jpi.io>
karasz
karasz approved these changes Jan 14, 2023
View reviewed changes
Copy link
Collaborator

@karasz karasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amery amery merged commit 0836b73 into master Jan 14, 2023
@amery amery deleted the pr-amery-buildsys branch January 14, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karasz karasz karasz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amery @karasz