Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uint8 in staking precompile is too small? #1422

Closed
hackfisher opened this issue Mar 1, 2024 · 3 comments · Fixed by #1425
Closed

uint8 in staking precompile is too small? #1422

hackfisher opened this issue Mar 1, 2024 · 3 comments · Fixed by #1425
Assignees
@boundless-forest @JayJay1024
Labels
B-Runtime [Bug] Some mistakes with the runtime logic P-High [Priority] High S-Need Audit PR contains changes to fund-managing logic that should be properly reviewed and externally audited

Comments

@hackfisher
Copy link
Contributor

darwinia/precompile/metadata/abi/staking.json

Line 141 in 7d1ad6f

"type": "uint8[]"

@hackfisher hackfisher added B-Runtime [Bug] Some mistakes with the runtime logic P-High [Priority] High S-Need Audit PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Mar 1, 2024
@hackfisher hackfisher changed the title uint8 in staking precompile is too small uint8 in staking precompile is too small? Mar 1, 2024
@AurevoirXavier
Copy link
Member

darwinia/runtime/darwinia/src/pallets/deposit.rs

Line 48 in 7d1ad6f

type MaxDeposits = ConstU32<512>;

@JayJay1024 JayJay1024 mentioned this issue Mar 1, 2024
Closed
@hackfisher
Copy link
Contributor Author

Becareful about the vec

pub type Deposits<T: Config> =
		StorageMap<_, Blake2_128Concat, T::AccountId, BoundedVec<Deposit, T::MaxDeposits>>;

Does it need migration if change the size?

@hackfisher
Copy link
Contributor Author

hackfisher commented Mar 1, 2024 •
edited
Loading

darwinia/runtime/darwinia/src/pallets/deposit.rs

Line 48 in 7d1ad6f

type MaxDeposits = ConstU32<512>;

This do not need change for this time, the type in the stake precompile need to be changed to a larger one, uint16

@boundless-forest boundless-forest linked a pull request Mar 4, 2024 that will close this issue
Update staking precompile method #1425
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boundless-forest boundless-forest

@JayJay1024 JayJay1024

Labels
B-Runtime [Bug] Some mistakes with the runtime logic P-High [Priority] High S-Need Audit PR contains changes to fund-managing logic that should be properly reviewed and externally audited
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update staking precompile method darwinia-network/darwinia
4 participants
@hackfisher @boundless-forest @AurevoirXavier @JayJay1024