Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update staking precompile method #1425

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Conversation

boundless-forest
Copy link
Member

@boundless-forest boundless-forest commented Mar 4, 2024

@JayJay1024 Please note the status of this PR, some methods selectors have changed.

@boundless-forest boundless-forest linked an issue Mar 4, 2024 that may be closed by this pull request
Copy link
Contributor

@hackfisher hackfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JayJay1024 Please be aware of these ABI changes.

@JayJay1024
Copy link

@JayJay1024 Please be aware of these ABI changes.

Got it. Will Crab and Darwinia be upgraded at the same time?

@boundless-forest
Copy link
Member Author

Got it. Will Crab and Darwinia be upgraded at the same time?

No, Crab first, then Darwina in the past. Pay attention to the governance voting channel.

@JayJay1024
Copy link

Got it. Will Crab and Darwinia be upgraded at the same time?

No, Crab first, then Darwina in the past. Pay attention to the governance voting channel.

Okay

@hackfisher hackfisher added the Bk-API [Break] This changes API; next release should be major. label Mar 4, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

github-actions bot commented Mar 4, 2024

Check ccf41b4 crab-dev

Check runtime version

Check runtime storage

- Pallet: "BridgeDarwiniaMessages"
- Pallet: "BridgePolkadotGrandpa"
- Pallet: "BridgePolkadotParachain"
- Pallet: "DarwiniaFeeMarket"

Pallet DarwiniaStaking
+ Entry: StorageEntryMetadata { name: "MigrationStartBlock", modifier: Default, ty: Plain(UntrackedSymbol { id: 4, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0, 0, 0, 0], docs: [" Migration starting block."] }

Copy link

github-actions bot commented Mar 4, 2024

Check ccf41b4 pangoro-dev

Check runtime version

Check runtime storage

Copy link

github-actions bot commented Mar 4, 2024

Check ccf41b4 darwinia-dev

Check runtime version

Check runtime storage

- Pallet: "BridgeCrabMessages"
- Pallet: "BridgeKusamaGrandpa"
- Pallet: "BridgeKusamaParachain"
- Pallet: "CrabFeeMarket"

Pallet DarwiniaStaking
+ Entry: StorageEntryMetadata { name: "MigrationStartBlock", modifier: Default, ty: Plain(UntrackedSymbol { id: 4, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0, 0, 0, 0], docs: [" Migration starting block."] }

Copy link

github-actions bot commented Mar 4, 2024

Check ccf41b4 pangolin-dev

Check runtime version

Check runtime storage

- Pallet: "BridgeMoonbaseGrandpa"
- Pallet: "BridgeMoonbaseParachain"
- Pallet: "BridgePangoroMessages"
- Pallet: "PangoroFeeMarket"

@AurevoirXavier AurevoirXavier merged commit c75d14c into main Mar 4, 2024
12 checks passed
@AurevoirXavier AurevoirXavier deleted the bear-fix-precompile-methods branch March 4, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bk-API [Break] This changes API; next release should be major.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

uint8 in staking precompile is too small?
4 participants