Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Read Status not updated immediately on toggle. #63

Closed
BaccanoMob opened this issue Dec 26, 2021 · 8 comments
Closed

[BUG] Read Status not updated immediately on toggle. #63

BaccanoMob opened this issue Dec 26, 2021 · 8 comments
Labels
bug Something isn't working

Comments

@BaccanoMob
Copy link

Earlier Toggle Read gave an error (at the time the API was not fixed). At the moment the endpoint was supposedly fixed
image
We get no errors but Ctrl + R is unresponsive and does not toggle. I even checked via website that the read status of chapters I tested were not updated.

@BaccanoMob BaccanoMob added the bug Something isn't working label Dec 26, 2021
@darylhjd
Copy link
Owner

We get no errors but Ctrl + R is unresponsive and does not toggle.

could you describe this more? (does the app freeze, does the table update, etc...)

my laptop died so i wont be able to diagnose this properly anytime soon.

@darylhjd
Copy link
Owner

darylhjd commented Dec 26, 2021

if possible, you can also copy paste the content of the log file for the run where you experienced this problem (you can just paste all the content of the file)

logs can be found in %AppData%/mangadesk/logs folder on Windows (which reminds me i might need to document this heh). You can just search for %AppData% on the windows search bar and it should open the correct directory.

@BaccanoMob
Copy link
Author

BaccanoMob commented Dec 26, 2021

if possible, you can also copy paste the content of the log file for the run where you experienced this problem (you can just paste all the content of the file)

was about to ask the location but the correct location is %AppData%/Roaming/mangadesk/logs , logs was not in %AppData%/local/mangadesk
and here you go

2021/12/26 17:50:14 logging.go:49: Session started at 2021-12-26 17-50-14
2021/12/26 17:50:15 main_page.go:40: Creating new main page...
2021/12/26 17:50:15 main_page.go:92: Using logged main page.
2021/12/26 17:50:15 service.go:27: Initialised starting screen.
2021/12/26 17:50:15 service.go:31: Running app...
2021/12/26 17:50:15 main_page.go:99: Setting logged grid...
2021/12/26 17:50:15 main_page.go:115: Setting logged table...
2021/12/26 17:50:15 main_page.go:110: Finished setting logged grid.
2021/12/26 17:50:15 main_page.go:204: Finished setting logged table.
2021/12/26 17:50:18 page_inputs.go:169: Selected row 7 on main page.
2021/12/26 17:50:18 manga_page.go:161: Setting up manga page chapter table...
2021/12/26 17:50:19 manga_page.go:295: Got 0 of 5 chapters
2021/12/26 17:50:22 modals.go:47: Removing toggle_read_chapters_modal modal
2021/12/26 17:50:24 modals.go:47: Removing toggle_read_chapters_modal modal

Apparently it only removes (i tried toggling twice like on off to see what happens)

@BaccanoMob
Copy link
Author

It should mark "Y" for when read and remove "Y" when changed to unread

and I hope this helps solve the issue

@darylhjd
Copy link
Owner

thanks. seems like ive already forgotten Windows stuff.

Apparently it only removes (i tried toggling twice like on off to see what happens)

so the app is able to toggle to unread but not to read?

It should mark "Y" for when read and remove "Y" when changed to unread

does the table update correctly?

@BaccanoMob
Copy link
Author

BaccanoMob commented Dec 26, 2021

I am really sorry, it apparently is working as intended while there is still a small bug.

So the mistake I made was i tried testing with single chapters. For example, I logged in and opened a manga page
image

  1. If press "Enter" as is, I get prompted if i should download the chapter(s). Meaning the highlighted chapter is selected.
  2. If I instead press "Ctrl+R", I get a prompt but nothing happens. Meaning the highlighted chapter is not selected for some reason. This is the small bug.

While if i use "Ctrl+E" like

  1. for single selection (top chapter)
    image

  2. for multiple selection (top 3 chapters)
    image

it works but the changes are not reflected instantaneously. So if I toggle with the above case. After confirming the prompt, It still looks like this
image
but upon leaving and entering the page again it looks like (the changes are applied)
image
Toggles correctly as seen with the chapter on top as well

TLDR
It would be nice if it was updated instantaneously as seen with the downloads.
And also for toggling only single chapters without Ctrl+E would be more convenient.

Since you mentioned your laptop died, I tried putting as detailed as possible. Hope it helps.

@BaccanoMob
Copy link
Author

also log states "Removing toggle_read_chapters_modal modal" whenever toggling whether marking as read or unread irrespective.

@darylhjd
Copy link
Owner

wow very detailed, thanks :)

i know what the problem is now haha, so ill work on it when i can!

the log is just showing the app removing the confirmation prompt (the modal), so no worries about that.

@darylhjd darylhjd changed the title [BUG] Toggle Read does not work [BUG] Read Status not updated immediately on toggle. Dec 28, 2021
@darylhjd darylhjd self-assigned this Dec 28, 2021
@darylhjd darylhjd removed their assignment Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants