Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for SRV records. #25

Merged
merged 2 commits into from
Dec 11, 2017
Merged

Remove support for SRV records. #25

merged 2 commits into from
Dec 11, 2017

Conversation

lambdafu
Copy link
Collaborator

This is based off #24 and removes support for SRV DNS records. SRV records are used to advertise alternative services in a domain are available, such as LDAP, XMPP or SIP. The SKS Keyserver HKP Pools use them to indicate the quality of a keyserver that is then accessed via http/https by their weights.

I removed support for SRV DNS records from NeoPG:

  • They are not supported by PGP.
  • Although interesting, the use of SRV weights to optimize the keyserver pool access is highly unorthodox for HTTP/HTTPS load balancing. I understand it is an attempt to eliminate the middle-man, but it is not clear what the threat model here is that motivates these complexities.
  • It is not supported by libcurl although it has been proposed 2006 specifically to support the use case in OpenPGP.
  • I know of no other keyserver pool doing this (or well, any other keyserver pool for that matter). It's an island.

If there ever will be curl support for it, we might reconsider this.

@lambdafu
Copy link
Collaborator Author

This feature, along with #24, also made it necessary to implement a special tor mode instead just relying on the socks5h proxy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant