Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom http client with libcurl #28

Merged
merged 3 commits into from
Dec 14, 2017
Merged

Replace custom http client with libcurl #28

merged 3 commits into from
Dec 14, 2017

Conversation

lambdafu
Copy link
Collaborator

@lambdafu lambdafu commented Dec 11, 2017

GnuPG has its own http client code. It is deeply intermangled with the custom dns resolver to support some unorthodox features (such as SRV DNS #25 and WKD #24), which we do not support. So we can revert back to libcurl and just write normal code. This will also be a precursor to removing the custom DNS resolver code.
In the future, we want to use Botan as TLS Backend to libcurl, and maybe link libcurl statically to minimize dependencies, make sure we get the Botan backend, and to limit the number of supported protocols to a manageable set. The downside of that will be to support the Windows build environment of libcurl.
There are other options beside libcurl (such as cppnet-lib), but they are usually tied to boost::asio, which is tied to openssl.

@lambdafu lambdafu force-pushed the yes-curl branch 4 times, most recently from 4e58454 to 0cd2bb7 Compare December 12, 2017 21:40
@codecov
Copy link

codecov bot commented Dec 12, 2017

Codecov Report

Merging #28 into master will decrease coverage by 12.85%.
The diff coverage is 55%.

@@             Coverage Diff             @@
##           master      #28       +/-   ##
===========================================
- Coverage     100%   87.14%   -12.86%     
===========================================
  Files          37       43        +6     
  Lines         450      630      +180     
  Branches       15       37       +22     
===========================================
+ Hits          450      549       +99     
- Misses          0       81       +81

@lambdafu lambdafu force-pushed the yes-curl branch 2 times, most recently from 0e5dc1c to 9b27d10 Compare December 14, 2017 00:55
@lambdafu lambdafu changed the title [WIP] Replace custom http client with libcurl Replace custom http client with libcurl Dec 14, 2017
@lambdafu lambdafu merged commit a16d821 into master Dec 14, 2017
@lambdafu lambdafu deleted the yes-curl branch December 14, 2017 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant