Replace custom http client with libcurl #28
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GnuPG has its own http client code. It is deeply intermangled with the custom dns resolver to support some unorthodox features (such as SRV DNS #25 and WKD #24), which we do not support. So we can revert back to libcurl and just write normal code. This will also be a precursor to removing the custom DNS resolver code.
In the future, we want to use Botan as TLS Backend to libcurl, and maybe link libcurl statically to minimize dependencies, make sure we get the Botan backend, and to limit the number of supported protocols to a manageable set. The downside of that will be to support the Windows build environment of libcurl.
There are other options beside libcurl (such as cppnet-lib), but they are usually tied to boost::asio, which is tied to openssl.