Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the name of a list #1520

Closed
benjamingeer opened this issue Nov 19, 2019 · 4 comments · Fixed by #1727
Closed

Updating the name of a list #1520

benjamingeer opened this issue Nov 19, 2019 · 4 comments · Fixed by #1727
Assignees
Labels
API/Admin question further information is requested

Comments

@benjamingeer
Copy link

CreateListApiRequestADM includes name, but ChangeListInfoApiRequestADM does not, is this correct?

@subotic
Copy link
Collaborator

subotic commented Nov 19, 2019

The name property is a bit under discussion. It is useful in import scripts if unique, but not really to useful IMO in the GUI.

@subotic subotic closed this as completed Nov 19, 2019
@subotic subotic reopened this Nov 19, 2019
@benjamingeer
Copy link
Author

The client API is supposed to be the same in all target languages, so the code generation doesn't support the idea of a property that would exist in only one target language.

@benjamingeer
Copy link
Author

It would also simplify the classes that need to be generated if the create request and the update request could be subclasses of a common base class.

@benjamingeer
Copy link
Author

Otherwise, there is more work to be done in the code generation algorithm to support this case (an update request that has an ID but no base class).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API/Admin question further information is requested
Projects
None yet
4 participants