feat (admin): Add edit list item route

[subotic]

Resolves #1387
Resolves #1528
Resolves #1520

[tobiasschweizer]

if you need my help integrating this PR into knora-api-s-lib, please let me know. Ideally, this would be automated, see #1554

[benjamingeer]

if you need my help integrating this PR into knora-api-s-lib, please let me know.

@tobiasschweizer Yes please. The semantics of the list update API have changed, so some of the existing client API functions and test data had to be replaced.

[tobiasschweizer]

What has changed exactly and how could this affect existing code?

[benjamingeer]

What has changed exactly and how could this affect existing code?

@tobiasschweizer The client function updateListInfo has been removed, and the following client functions have been added:

• updateListName
• updateListLabels
• updateListComments
• updateListNodeName
• updateListNodeLabels
• updateListNodeComments

Each of the new functions has new test data.

[tobiasschweizer]

So this means that the test for updateListInfo has to be removed and tests for the new methods have to be added using the new test data?

This may also affect @kilchenmann and @flavens since the admin method are already in use.

[benjamingeer]

So this means that the test for updateListInfo has to be removed and tests for the new methods have to be added using the new test data?

That's right.

This may also affect @kilchenmann and @flavens since the admin method are already in use.

Yes. I had understood that the existing functionality wouldn't be changed, but it looks like that wasn't feasible.

[LukasStoeckli]

Yes. I had understood that the existing functionality wouldn't be changed, but it looks like that wasn't feasible.

What functionality exactly? The update method being split up into one route per attribute?

[flavens]

@benjamingeer @LukasStoeckli @tobiasschweizer
this is how we use it at the moment:
this.knoraApiConnection.admin.listsEndpoint.updateListInfo(listInfoUpdateData).subscribe( (response: ApiResponseData<ListInfoResponse>) => { ... }
so, as Tobias explained us, we will have to rewrite and split this method with all the new methods to get the same info, which means quite a lot of refactoring for us actually..

[flavens]

@benjamingeer @LukasStoeckli will this PR be part of the next release?

[benjamingeer]

@flavens We can certainly wait if you need more time.

[flavens]

@flavens We can certainly wait if you need more time.

That would be great! We will do it in February to be part of R2020-02.

[SepidehAlassi]

The issues addressed in this PR are implemented in #1753.