DSP-740 Update List Name

[SepidehAlassi]

resolves DSP-740

also

• make labels, and comments in payload of update request optional.
• update documentation
• add tests
• add test data

closes #1520 and closes #1528

Note: This does not break JS-lib but Knora-py.

[benjamingeer]

If I understand correctly, the reason for the Option is that if you submit an empty list, it should remove all labels. Is that right? If so, could you add a test for that?

[SepidehAlassi]

no, if you submit labels=[] it will return a BedRequestException. At the time being, the idea is that the update route should not be used to delete the properties. This will change later.

[benjamingeer]

So why use Option?

[SepidehAlassi]

because without it, the user needs to repeat the labels and comments in the payload even if she wants to only change the name

[SepidehAlassi]

So when labels and comments are optional, user can simply use the following request body to update only the name of the list without having to give/repeat the values of labels and comments

   {
       "listIri": "listIri",
       "projectIri": "someprojectiri",
       "name": "another name"
  }

[benjamingeer]

OK, I understand, thanks.

[SepidehAlassi]

@benjamingeer I just added your points about making the checks clear. Also, the test data is added.

[subotic]

@SepidehAlassi could you add the fixed to the docs for PR #1724 in this PR?

Also, just found about it yesterday myself. We actually have developer guidelines regarding the naming of PRs: https://docs.dasch.swiss/developers/dsp/contribution/#pull-request-guidelines

[benjamingeer]

Looks good, thank you!

[SepidehAlassi]

@SepidehAlassi could you add the fixed to the docs for PR #1724 in this PR?

Also, just found about it yesterday myself. We actually have developer guidelines regarding the naming of PRs: https://docs.dasch.swiss/developers/dsp/contribution/#pull-request-guidelines

Done! :-)

[SepidehAlassi]

Looks good, thank you!

Thank you for reviewing this.

[SepidehAlassi]

@benjamingeer the update of expected-client-test-data.txt was missing, I committed it in a4db9d6. I am going to merge this PR after tests pass and make a new release candidate, is that ok for you?

[benjamingeer]

Yes please!