refactor: Introduce Value[A] and extract tapir and zio-json codecs
#2996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seakayone
changed the base branch from
main
to
refactor/migrate-admin-files-to-tapir
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2996 +/- ##
===========================================
+ Coverage 11.74% 88.58% +76.84%
===========================================
Files 246 259 +13
Lines 22907 23084 +177
===========================================
+ Hits 2690 20449 +17759
+ Misses 20217 2635 -17582 ☔ View full report in Codecov by Sentry. |
seakayone
changed the title
Value[A] and derive companion object with codecs for StringValuesValue[A] and extract tapir and zio-json codecs
Base automatically changed from
refactor/migrate-admin-files-to-tapir
to
main
January 18, 2024 08:14
…end StringBasedValueCompanionWithCodecs
seakayone
force-pushed
the
derive-codecs
branch
from
393cf38
to
fa9ccab
Compare
…l value which is by definition of the shortnameRegex already SPARQL safe.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Task Description/Number
Valuetrait for all of our value classes to be based on.WithFromtrait which respective companion objects may use for adding anunsafeFromfactory method.StringandBooleanvalues, we can add more once we need them.zio.jsonandsttp.tapirdependencies forKnoraProjectand releated value classes and moves these to…admin.api.CodecsValidationreturn types in all factory methods ofKnoraProjectvalue classes with a simpleEither[String, A]AssetPermissionRespondertoAssetPermissionsResponderPR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?