Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix UserIri and allow existing values (DEV-3194) #2997

Merged
merged 8 commits into from
Jan 19, 2024

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Jan 18, 2024

Pull Request Checklist

Task Description/Number

This PR depends on #2996 being merged first.

Widen the allowed range of UserIris to account for existing iris in our database

  • Allows for builtIn UserIris
  • Regular UserIris start with http://rdfh.ch/users/ and then an alphanumeric String containing - or _ is allows, length >=4 and <=36 charaters
  • Adds isBuiltInUser and isRegularUser extension methods to UserIri
  • Moves creating a new UserIri from the StringFormatter to UserIri.makeNew
  • Migrates the DELETE admin/users/iri/{userIri} route to tapir

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone changed the title fix: Fix user iri allow existing values fix: Fix UserIri and allow existing values (DEV-3194) Jan 18, 2024
Copy link

linear bot commented Jan 18, 2024

@seakayone seakayone changed the base branch from main to derive-codecs January 18, 2024 14:51
@seakayone seakayone self-assigned this Jan 18, 2024
@seakayone seakayone marked this pull request as ready for review January 18, 2024 14:51
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eac5751) 11.74% compared to head (c2a1109) 11.64%.
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2997      +/-   ##
==========================================
- Coverage   11.74%   11.64%   -0.10%     
==========================================
  Files         246      259      +13     
  Lines       22907    23094     +187     
==========================================
- Hits         2690     2689       -1     
- Misses      20217    20405     +188     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Both suggestions below can be applied separately to have this merged ASAP and release.

Base automatically changed from derive-codecs to main January 19, 2024 08:48
@seakayone seakayone force-pushed the fix/fix-user-iri-allow-existing-values branch from aa62184 to c2a1109 Compare January 19, 2024 08:54
@seakayone seakayone enabled auto-merge (squash) January 19, 2024 08:56
@seakayone seakayone merged commit ecf9c0a into main Jan 19, 2024
13 checks passed
@seakayone seakayone deleted the fix/fix-user-iri-allow-existing-values branch January 19, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants