Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit list items #50

Closed
kilchenmann opened this issue Aug 23, 2019 · 8 comments
Closed

Edit list items #50

kilchenmann opened this issue Aug 23, 2019 · 8 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@kilchenmann
Copy link
Contributor

kilchenmann commented Aug 23, 2019

Is your feature request related to a problem? Please describe.
In the next release (2019-09) it's possible to create lists and add new item. But there's no possibility yet to edit or delete list items or to reorder them.

Describe the solution you'd like
Update list-item-form to edit.

Additional context
This feature needs the implementation of the StringLiteral form component to support multi-language inputs. I already started with a prototype of this form in knora-ui-playground

@kilchenmann kilchenmann self-assigned this Aug 23, 2019
@kilchenmann kilchenmann added the enhancement New feature or request label Aug 23, 2019
@kilchenmann kilchenmann added this to the 2019-09 milestone Aug 23, 2019
@kilchenmann
Copy link
Contributor Author

kilchenmann commented Aug 26, 2019

In the list editor we read the project shortcode from the IRI. In some cases (e.g. BEOL) the IRI doesn't contain the shortcode and we get some 400-errors from the API. We have to improve the existing solution. (#57)

In the test-data of BEOL is a wrong IRI but I have to read the shortcode from the IRI. In this (only in this) case, the shortcode is not part of the beol iri.

@kilchenmann
Copy link
Contributor Author

The input field of label has a default max length of 16. This should be fixed by implementing StringLiteral-input field

@flavens flavens changed the title Edit list items feat: Edit list items Aug 29, 2019
@kilchenmann
Copy link
Contributor Author

kilchenmann commented Sep 8, 2019

We have to clean up the file / component structure for the lists.

  • list.component contains a list of lists in expansion panels (mat-accordion module)
  • the mat-accordion contains the recursive list-item.component and list-item-form.component to add / edit list items (an item is the same as node)
  • additional there should be a create / edit button to create the list or edit the list-info itself. list-info-form.component opens in mat-dialog.

@kilchenmann
Copy link
Contributor Author

kilchenmann commented Sep 8, 2019

Todo:

  • Fix issue with project id; we can't use the shortcode to create the iri Comment 524880326
  • list-info-form: implement stringLiteral and remove language selection
  • clean up file / component structure; make it simpler
  • update dialog component: remove unused list sections
  • language support for stringLiterals; at the moment we read the first item only
    --> what's about one language selector at the top?
  • fix issues with the stringLiteral implementation
  • edit list info
  • main language switch --> doesn't seem to work yet
  • fix styling issues
  • display stringLiteral value in user's default language Improvements on the StringLiteral Input knora-ui#318 / s. comment

@kilchenmann
Copy link
Contributor Author

kilchenmann commented Sep 8, 2019

I suggest to prepare everything in Kuirl with status 'disabled' 'readonly' until Knora admin api supports the list editing. Don't forget to update the Knora-ui core module listsService

@flavens
Copy link
Contributor

flavens commented Sep 19, 2019

@kilchenmann should we move this issue to the next milestone 10-2019??

@kilchenmann
Copy link
Contributor Author

@flavens: Not sure. Let's see how fast @subotic will be with implementing the knora api part to edit list nodes. Otherwise we can still postpone it...

@kilchenmann kilchenmann modified the milestones: 2019-09, 2019-10 Sep 24, 2019
@kilchenmann kilchenmann changed the title feat: Edit list items Edit list items Sep 30, 2019
@kilchenmann kilchenmann modified the milestones: 2019-10, 2019-11 Oct 28, 2019
@subotic subotic modified the milestones: 2019-11, 2019-12 Nov 27, 2019
@flavens flavens modified the milestones: 2019-12, 2020-01 Dec 13, 2019
@flavens flavens removed this from the 2020-01 milestone Jan 20, 2020
@flavens flavens added this to the 2020-03 milestone Jan 20, 2020
@subotic subotic modified the milestones: 2020-03, 2020-01 Feb 7, 2020
@flavens
Copy link
Contributor

flavens commented May 27, 2020

some tasks have been completed + there are some opened issues in knora-api related to this one and already on YouTrack #1387, #1388 and #1389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants