Pre-release v1.4.0 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am on it! |
|
@kilchenmann I can not edit a list item, I get a 400 error, is it only me? |
|
@flavens I will test... |
|
I don't get an error on the lists. I'm able to edit list-info and to add new list nodes but also to create new lists |
|
But why it shouldn't work anymore? I worked on 5 files only in this branch |
|
Ok so I can edit a list in the anything project but not in the BEOL project... Maybe there are some permissions on it?! Anyway except this point, I can approve the PR if there is nothing more to fix/add! |
|
In the test-data of BEOL is a wrong IRI but I have to read the shortcode from the IRI. In this (only in this) case, the shortcode is not part of the beol iri. This is something we have to fix when we make the list editor better |
Closed
flavens
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.