DSP-777 Show message on all server errors in login component #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you give me a short explanation on how to test this please? |
|
@mdelez Sure. You can turn of the database for example: Stop the corresponding docker container. You can use the docker dashboard for this or the command line with |
|
When knora-stack is not running (no api, no db, no sipi, no salsah) you get a status 0
|
|
In case of a broken knora-stack (maybe only the api is running), you get a 503 error:
|
mdelez
suggested changes
Oct 5, 2020
projects/dsp-ui/src/lib/action/components/login-form/login-form.component.ts
Outdated
Show resolved
Hide resolved
mdelez
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DSP-777