Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSP-779 Display error messages directly and not only in console #201

Merged
merged 16 commits into from
Oct 7, 2020

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented Oct 5, 2020

resolves DSP-779

For the reviewers:

@kilchenmann kilchenmann self-assigned this Oct 5, 2020
@kilchenmann kilchenmann added the enhancement New feature or request label Oct 5, 2020
@kilchenmann kilchenmann marked this pull request as draft October 5, 2020 15:47
@kilchenmann kilchenmann marked this pull request as ready for review October 6, 2020 08:53

<!-- Action: Contact DSP support -->
<a mat-button class="action" href="https://docs.dasch.swiss/community/faq" target="_blank">
<mat-icon>mail_outline</mat-icon> Contact DSP support
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DSP or DaSCH? Yesterday we used DaSCH #200

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DaSCH
I will update

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated (e10af34) with "Contact the support team" as mentioned in this comment:
https://dasch.myjetbrains.com/youtrack/issue/DSP-710#focus=Comments-4-1211.0-0

@@ -18,37 +19,62 @@ export class DspMessageData {
url?: string;
}

export class tmpApiResponseError {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this used anywhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups... I forgot to remove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved in e10af34

Copy link
Contributor

@mdelez mdelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

Copy link
Collaborator

@flavens flavens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, however I am not sure that the Contact link should go to the FAQ page (see my comments)

</p>

<!-- Action: Contact DaSCH/DSP support -->
<a mat-button class="action" href="https://docs.dasch.swiss/community/faq" target="_blank">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when you write "Contact the support team", most of users will expect an email address because clicking twice to land on Discuss - an app they do not know how to use - will lead to frustration and lost of tracks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I know. This should be a temporary solution and I wanted to update the documentation with a support page. This page doesn't exist yet. And discuss.dass.swiss will not be the support contact page. This has to improved and we have to think about a "Contact email-address".

With the monitoring, which is at the moment only implemented on main server, the support team should get an error report as soon the system fails. This is part of status report on https://status.dasch.swiss

So, it doesn't make sense to have an e-mail-address and getting a lot of e-mails from users and anyway we didn't had the e-mail-address support@dasch.swiss until yesterday evening.

The part of support in case of a server error should be handled in an additional PR...

@kilchenmann kilchenmann merged commit 6433657 into master Oct 7, 2020
@kilchenmann kilchenmann deleted the wip/dsp-779-error-message-search-results branch October 7, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants