Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSP-657 Handle links in XML text values #202

Merged
merged 14 commits into from
Oct 7, 2020

Conversation

tobiasschweizer
Copy link
Contributor

@tobiasschweizer tobiasschweizer commented Oct 5, 2020

resolves DSP-657

@tobiasschweizer tobiasschweizer self-assigned this Oct 5, 2020
@tobiasschweizer tobiasschweizer added the enhancement New feature or request label Oct 6, 2020
@tobiasschweizer
Copy link
Contributor Author

tobiasschweizer commented Oct 6, 2020

@flavens @mdelez @kilchenmann
This PR adds a directive with two @Outputs to react to click and hover events on internal links in text values with markup.

I wonder how this could be integrated in the resource viewer. Could the resource viewer propagate these events, so when used in an app, the behavior could be defined.

I think the resource viewer could have one @Ouptput for click events on internal links that would combine:

  • clicks on an link value in read-mode
  • clicks on an internal link in a text value with markup in read-mode

see https://dasch.myjetbrains.com/youtrack/issue/DSP-784

Copy link
Contributor

@mdelez mdelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@tobiasschweizer
Copy link
Contributor Author

@flavens I think #203 will also handle external links in HTML text values in read-mode. However, could we make sure it does not affect the markup inside CKEditor (when the HTML is being edited)?

@flavens
Copy link
Collaborator

flavens commented Oct 7, 2020

@flavens I think #203 will also handle external links in HTML text values in read-mode. However, could we make sure it does not affect the markup inside CKEditor (when the HTML is being edited)?

I can check that

@tobiasschweizer
Copy link
Contributor Author

@flavens I think #203 will also handle external links in HTML text values in read-mode. However, could we make sure it does not affect the markup inside CKEditor (when the HTML is being edited)?

I can check that

Great, thank you. If I can help you, let me know.

@tobiasschweizer tobiasschweizer merged commit c0522e6 into master Oct 7, 2020
@tobiasschweizer tobiasschweizer deleted the wip/dsp-657-internal-links-in-XML-value branch October 7, 2020 08:32
@kilchenmann kilchenmann changed the title Handle links in XML text values DSP-657 Handle links in XML text values Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants