-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DSP-657 Handle links in XML text values #202
DSP-657 Handle links in XML text values #202
Conversation
@flavens @mdelez @kilchenmann I wonder how this could be integrated in the resource viewer. Could the resource viewer propagate these events, so when used in an app, the behavior could be defined. I think the resource viewer could have one
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice :)
resolves DSP-657
display external links in read-mode for standard mapping (coordinate with https://dasch.myjetbrains.com/youtrack/issue/DSP-297)
react to clicking on internal links in read-mode for standard mapping
try to use
@HostListener
: https://github.com/dhlab-basel/beol/blob/04c11b712246236cdba732689997bb12d025c888/src/app/directives/mathjax.directive.ts#L242-L375 for internal links: target resource should be shown in the resource vieweradd target: '_blank' to attributes for external links so that they open in a new tab -> this might be solved in https://dasch.myjetbrains.com/youtrack/issue/DSP-297