Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DSP-JS-Lib #209

Merged
merged 7 commits into from
Oct 12, 2020
Merged

Update DSP-JS-Lib #209

merged 7 commits into from
Oct 12, 2020

Conversation

kilchenmann
Copy link
Contributor

  • Update DSP-JS-Lib to version v1.0.0-rc.13
  • Update CHANGELOG

@kilchenmann kilchenmann self-assigned this Oct 12, 2020
tobiasschweizer
tobiasschweizer reviewed Oct 12, 2020
View reviewed changes
CHANGELOG.md Outdated

## Breaking changes

- #199 Integrate Ckeditor into Property View
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we link to the PRs like in dsp-js?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was https://dasch.myjetbrains.com/youtrack/issue/DSP-682, the PR's description contains additional information about the breaking change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me check...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to update some titles of already closed PRs and update the "Next Release" draft. Now the changelog file should be good

@kilchenmann kilchenmann merged commit 948f908 into master Oct 12, 2020
@kilchenmann kilchenmann deleted the wip/update-dsp-js-lib branch October 12, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasschweizer tobiasschweizer tobiasschweizer approved these changes

@flavens flavens flavens approved these changes

Assignees

@kilchenmann kilchenmann

Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kilchenmann @tobiasschweizer @flavens