DSP-759 Check if a Given Date Can Be Edited / Rename ValueTypeService to ValueService #214

tobiasschweizer · 2020-10-29T07:35:02Z

resolves DSP-759

Note that this PR renames ValueTypeService to ValueService.

…icker

tobiasschweizer · 2020-10-29T15:02:22Z

@mdelez This PR handles precision and era, but not the calendar.

tobiasschweizer · 2020-10-29T15:28:32Z

@mdelez sorry, too early to review: still missing the logic the prevents the editing button to show up (isReadonly)

# Conflicts: # projects/dsp-ui/src/lib/viewer/values/date-value/date-value.component.ts

tobiasschweizer · 2020-10-30T08:09:00Z

@mdelez Ok, now this PR is ready for review :-)

I decided to move the logic to value type service since it is also used there. It seemed weird to me to use logic coming from a component in a service.

tobiasschweizer · 2020-10-30T08:09:46Z

projects/dsp-ui/src/lib/viewer/services/value-type.service.ts

+    isTextEditable(textValue: ReadTextValueAsXml): boolean {
+        return textValue.mapping === 'http://rdfh.ch/standoff/mappings/StandardMapping';
+    }
+
    /**
     * Equality checks with constants below are TEMPORARY until component is implemented.


@mdelez Maybe this comment should be adapted since there are also other reasons to make a value read-only. What do you think?

I agree, it's strayed away from its initial purpose so the comment should be updated. Maybe something like "Determines if the editing the given value is supported"

Maybe this service can also be renamed? It's becoming more general and is now more of a place to add helpful functions for the value components

mdelez

Nice! Just left a few comments to discuss

mdelez · 2020-10-30T08:53:15Z

projects/dsp-ui/src/lib/viewer/services/value-type.service.ts

+    isTextEditable(textValue: ReadTextValueAsXml): boolean {
+        return textValue.mapping === 'http://rdfh.ch/standoff/mappings/StandardMapping';
+    }
+
    /**
     * Equality checks with constants below are TEMPORARY until component is implemented.


I agree, it's strayed away from its initial purpose so the comment should be updated. Maybe something like "Determines if the editing the given value is supported"

mdelez · 2020-10-30T09:01:21Z

projects/dsp-ui/src/lib/viewer/services/value-type.service.ts

+    isTextEditable(textValue: ReadTextValueAsXml): boolean {
+        return textValue.mapping === 'http://rdfh.ch/standoff/mappings/StandardMapping';
+    }
+
    /**
     * Equality checks with constants below are TEMPORARY until component is implemented.


Maybe this service can also be renamed? It's becoming more general and is now more of a place to add helpful functions for the value components

tobiasschweizer · 2020-11-02T08:24:01Z

Nice! Just left a few comments to discuss

I adapted the comment and renamed the service in b918f64.

I renamed the service to ValueService because it is not only about the value's type (the value instance is checked too).

Do you know if this service is used directly somewhere (outside the lib)? If yes, usage would break with the next release.

mdelez · 2020-11-02T08:31:36Z

Do you know if this service is used directly somewhere (outside the lib)? If yes, usage would break with the next release.

It is used here in DSP-APP. However, the PR that this code is in isn't merged yet so we can update it easily :)

tobiasschweizer · 2020-11-02T08:37:52Z

Do you know if this service is used directly somewhere (outside the lib)? If yes, usage would break with the next release.

It is used here in DSP-APP. However, the PR that this code is in isn't merged yet so we can update it easily :)

Ok, great! I adapted the vars as well in 3389906

tobiasschweizer · 2020-11-02T08:41:25Z

projects/dsp-ui/src/lib/viewer/operations/display-edit/display-edit.component.spec.ts

@@ -324,14 +322,11 @@ describe('DisplayEditComponent', () => {
        {
            provide: MatDialogRef,
            useValue: {}
-        },
-        ValueService,


@mdelez I think there is no need to provide the service here since it is provided in root anyway.
Importing ReactiveFormsModule fixes the injector problem with FormBuilder.

However, I am not really sure what the best way is. Maybe we should spend some time on https://dasch.myjetbrains.com/youtrack/issue/DSP-98

I'm currently writing unit tests for the PR mentioned above and the imports/injections (in test host components) for the FormBuilder are quite confusing. I think we should spend some time on what exactly needs to be imported in the unit tests so that you don't get an injector error.

That is an excellent idea. Maybe we could try to work on https://dasch.myjetbrains.com/youtrack/issue/DSP-98 soon.

* main: Update dependencies (#219) Create user service (#217) DSP-759 Check if a Given Date Can Be Edited (#214) DSP-920 Renaming default github branch to "main" (#216) DSP-881 - Value Component Base Class Changes (#210) chore (package.json): update dsp-js-lib and adapt assertions (#215) DSP-522 Refactor search panel style (#206) Wip/dsp 885 default gravsearch query (#211) # Conflicts: # Makefile ( DSP-987 ) Still a bug in expert search ( DSP-885 ) Expert search default/example Gravsearch query throws a 400 Bad Request error

feature (viewer): check if a given date can be edited using the datep…

d6427c1

…icker

tobiasschweizer changed the title ~~Check if a Given Date can be Edited~~ Check if a Given Date Can Be Edited Oct 29, 2020

Tobias Schweizer added 2 commits October 29, 2020 08:36

tests (viewer): check if a given date can be edited using the datepicker

d100929

tests (viewer): check if a given date can be edited using the datepicker

5a52dd9

tobiasschweizer self-assigned this Oct 29, 2020

tobiasschweizer added the enhancement New feature or request label Oct 29, 2020

Tobias Schweizer and others added 2 commits October 29, 2020 10:12

refactor (viewer): make methods for era and precision checking

faecdb0

Merge branch 'master' into wip/dsp-759-edit-date

939eaa8

tobiasschweizer requested a review from mdelez October 29, 2020 15:01

feature (viewer): make unsupported dates readonly

02c4116

kilchenmann changed the base branch from master to main October 29, 2020 16:50

kilchenmann changed the title ~~Check if a Given Date Can Be Edited~~ DSP-759 Check if a Given Date Can Be Edited Oct 29, 2020

Tobias Schweizer added 2 commits October 30, 2020 08:39

Merge branch 'main' into wip/dsp-759-edit-date

4024f2d

# Conflicts: # projects/dsp-ui/src/lib/viewer/values/date-value/date-value.component.ts

refactor (viewer): move date checking logic to value type service

00ae2b6

tobiasschweizer commented Oct 30, 2020

View reviewed changes

fix (viewer): remove console log

f11fb8a

mdelez suggested changes Oct 30, 2020

View reviewed changes

refactor (viewer): rename service

b918f64

Merge branch 'main' into wip/dsp-759-edit-date

f120c97

refactor (service): rename service vars consistently

3389906

tobiasschweizer added the breaking Breaking change label Nov 2, 2020

tobiasschweizer commented Nov 2, 2020

View reviewed changes

mdelez self-requested a review November 2, 2020 08:49

mdelez approved these changes Nov 2, 2020

View reviewed changes

tobiasschweizer merged commit d0db068 into main Nov 2, 2020

tobiasschweizer deleted the wip/dsp-759-edit-date branch November 2, 2020 08:59

mdelez mentioned this pull request Nov 2, 2020

DSP-851 New resource form dasch-swiss/dsp-das#321

Merged

kilchenmann changed the title ~~DSP-759 Check if a Given Date Can Be Edited~~ DSP-759 Check if a Given Date Can Be Edited / renames ValueTypeService to ValueService Dec 11, 2020

kilchenmann changed the title ~~DSP-759 Check if a Given Date Can Be Edited / renames ValueTypeService to ValueService~~ DSP-759 Check if a Given Date Can Be Edited / Rename ValueTypeService to ValueService Dec 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DSP-759 Check if a Given Date Can Be Edited / Rename ValueTypeService to ValueService #214

DSP-759 Check if a Given Date Can Be Edited / Rename ValueTypeService to ValueService #214

tobiasschweizer commented Oct 29, 2020 •

edited

Loading

tobiasschweizer commented Oct 29, 2020

tobiasschweizer commented Oct 29, 2020 •

edited

Loading

tobiasschweizer commented Oct 30, 2020

tobiasschweizer Oct 30, 2020

mdelez Oct 30, 2020 •

edited

Loading

mdelez Oct 30, 2020

mdelez left a comment

mdelez Oct 30, 2020 •

edited

Loading

mdelez Oct 30, 2020

tobiasschweizer commented Nov 2, 2020

mdelez commented Nov 2, 2020

tobiasschweizer commented Nov 2, 2020

tobiasschweizer Nov 2, 2020

tobiasschweizer Nov 2, 2020

mdelez Nov 2, 2020 •

edited

Loading

tobiasschweizer Nov 2, 2020

DSP-759 Check if a Given Date Can Be Edited / Rename ValueTypeService to ValueService #214

DSP-759 Check if a Given Date Can Be Edited / Rename ValueTypeService to ValueService #214

Conversation

tobiasschweizer commented Oct 29, 2020 • edited Loading

tobiasschweizer commented Oct 29, 2020

tobiasschweizer commented Oct 29, 2020 • edited Loading

tobiasschweizer commented Oct 30, 2020

tobiasschweizer Oct 30, 2020

Choose a reason for hiding this comment

mdelez Oct 30, 2020 • edited Loading

Choose a reason for hiding this comment

mdelez Oct 30, 2020

Choose a reason for hiding this comment

mdelez left a comment

Choose a reason for hiding this comment

mdelez Oct 30, 2020 • edited Loading

Choose a reason for hiding this comment

mdelez Oct 30, 2020

Choose a reason for hiding this comment

tobiasschweizer commented Nov 2, 2020

mdelez commented Nov 2, 2020

tobiasschweizer commented Nov 2, 2020

tobiasschweizer Nov 2, 2020

Choose a reason for hiding this comment

tobiasschweizer Nov 2, 2020

Choose a reason for hiding this comment

mdelez Nov 2, 2020 • edited Loading

Choose a reason for hiding this comment

tobiasschweizer Nov 2, 2020

Choose a reason for hiding this comment

tobiasschweizer commented Oct 29, 2020 •

edited

Loading

tobiasschweizer commented Oct 29, 2020 •

edited

Loading

mdelez Oct 30, 2020 •

edited

Loading

mdelez Oct 30, 2020 •

edited

Loading

mdelez Nov 2, 2020 •

edited

Loading