-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #219
Update dependencies #219
Conversation
kilchenmann
commented
Nov 3, 2020
•
edited
Loading
edited
- Update DSP-JS to v1.0.0-rc.15
- Update Makefile setup by using vars.mk and update README
- Prepare next release (in the previous release I have selected the wrong base branch)
- New CI feature: Update CHANGELOG on release only and attach to release assets and to build (DSP-978)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to keep the changelog in the repo and update it automatically?
@@ -41,6 +41,7 @@ npm-debug.log | |||
yarn-error.log | |||
testem.log | |||
/typings | |||
CHANGELOG.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean that there is no changelog file that is part of the git repo?
So the changelog is always dynamically generated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately there is no way to keep the changelog in the repo and update it automatically. Because each change in the changelog will always need a commit and we can't commit automatically to base branch. The changelog is anyway not up-to-date in the base branch.
We decided to generate it automatically and add it to the release assets and to the build before publishing to npm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it's always accessible in the release assets as a file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, exactly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, then it's totally fine.
* main: Update dependencies (#219) Create user service (#217) DSP-759 Check if a Given Date Can Be Edited (#214) DSP-920 Renaming default github branch to "main" (#216) DSP-881 - Value Component Base Class Changes (#210) chore (package.json): update dsp-js-lib and adapt assertions (#215) DSP-522 Refactor search panel style (#206) Wip/dsp 885 default gravsearch query (#211) # Conflicts: # Makefile ( DSP-987 ) Still a bug in expert search ( DSP-885 ) Expert search default/example Gravsearch query throws a 400 Bad Request error