Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #219

Merged
merged 9 commits into from
Nov 3, 2020
Merged

Update dependencies #219

merged 9 commits into from
Nov 3, 2020

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented Nov 3, 2020

  • Update DSP-JS to v1.0.0-rc.15
  • Update Makefile setup by using vars.mk and update README
  • Prepare next release (in the previous release I have selected the wrong base branch)
  • New CI feature: Update CHANGELOG on release only and attach to release assets and to build (DSP-978)

@kilchenmann kilchenmann self-assigned this Nov 3, 2020
Copy link
Contributor

@tobiasschweizer tobiasschweizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to keep the changelog in the repo and update it automatically?

@@ -41,6 +41,7 @@ npm-debug.log
yarn-error.log
testem.log
/typings
CHANGELOG.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that there is no changelog file that is part of the git repo?
So the changelog is always dynamically generated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately there is no way to keep the changelog in the repo and update it automatically. Because each change in the changelog will always need a commit and we can't commit automatically to base branch. The changelog is anyway not up-to-date in the base branch.
We decided to generate it automatically and add it to the release assets and to the build before publishing to npm.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it's always accessible in the release assets as a file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, exactly

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, then it's totally fine.

@kilchenmann kilchenmann merged commit 15aae79 into main Nov 3, 2020
@kilchenmann kilchenmann deleted the wip/update-dsp-js branch November 3, 2020 09:37
RalfBarkow pushed a commit that referenced this pull request Nov 4, 2020
* main:
  Update dependencies (#219)
  Create user service (#217)
  DSP-759 Check if a Given Date Can Be Edited (#214)
  DSP-920 Renaming default github branch to "main" (#216)
  DSP-881 - Value Component Base Class Changes (#210)
  chore (package.json): update dsp-js-lib and adapt assertions (#215)
  DSP-522 Refactor search panel style (#206)
  Wip/dsp 885 default gravsearch query (#211)

# Conflicts:
#	Makefile

( DSP-987 ) Still a bug in expert search
( DSP-885 ) Expert search default/example Gravsearch query throws a 400 Bad Request error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants