Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evolve addToPlaylist() #190

Closed
dascritch opened this issue Sep 28, 2022 · 3 comments
Closed

Evolve addToPlaylist() #190

dascritch opened this issue Sep 28, 2022 · 3 comments
Milestone
7.1

Comments

@dascritch
Copy link
Owner

dascritch commented Sep 28, 2022 •
edited
Loading

This function, sit in build_playlist.js has some TODO :

		// TODO do not rerecord id if already in this playlist. Remove from other playlists
		// TODO LATER, remove id when cpu-audio or audiotag removed

It may be useful. And also, add some tests/TDD

Lot of functions have forgotten TODO
@dascritch dascritch added this to the 7.1 milestone Sep 28, 2022
@dascritch
Copy link
Owner Author

About : // TODO LATER, remove id when cpu-audio or audiotag removed , we have a warning in console, so not useful to fix.

@dascritch
Copy link
Owner Author

Also : // TODO do not rerecord id if already in this playlist. Remove from other playlists , well in fact, it may be intentionnal.

@dascritch
Copy link
Owner Author

So : won't fix

dascritch pushed a commit that referenced this issue Sep 30, 2022
Won't fix
a12d234 
Evolve addToPlaylist() #190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.1
Development

No branches or pull requests
1 participant
@dascritch