Clarify documentation for :on_success and :on_failure #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanl
commented
Sep 24, 2020
| requeues the message. | ||
| that it can be delivered to a consumer again. `:reject_and_requeue` | ||
| always requeues the message. If the message is unprocessable, this will | ||
| cause an infinite loop of retries. |
There was a problem hiding this comment.
The infinite loop of retries bit us in production, which is why I think this clarification is important.
I would like to suggest that, rather than defaulting to :reject_and_requeue, the user be required to specify one of these options. This would prompt them to consider the tradeoffs.
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.