Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

feat: handle Unavailable ABCI error #337

Merged
merged 2 commits into from
Feb 8, 2021
Merged

feat: handle Unavailable ABCI error #337

merged 2 commits into from
Feb 8, 2021

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Feb 8, 2021

Issue being fixed or feature implemented

In case of the previous state is unavailable, Drive throws an Unavailable ABCI error which should be converted in appropriate gRPC error

What was done?

  • Respond with Unavailable gRPC error if Unavailable ABCI error occurred.

How Has This Been Tested?

With tests

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov requested a review from antouhou February 8, 2021 15:32
@shumkov shumkov changed the title feat: handle "unavailable" ABCI error feat: handle unavailable ABCI error Feb 8, 2021
@shumkov shumkov changed the title feat: handle unavailable ABCI error feat: handle Unavailable ABCI error Feb 8, 2021
@shumkov shumkov added this to the v0.18 milestone Feb 8, 2021
@shumkov shumkov merged commit fd79174 into v0.18-dev Feb 8, 2021
@shumkov shumkov deleted the handle-unavailable-error branch February 8, 2021 16:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antouhou antouhou antouhou approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v0.18
Development

Successfully merging this pull request may close these issues.
2 participants
@shumkov @antouhou