This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
feat: implement getConsensusParams method #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package-lock.json # package.json
# Conflicts: # package.json
shumkov
reviewed
Aug 11, 2021
Comment on lines
46
to
50
| if (e instanceof RPCError) { | ||
| throw new InternalGrpcError(e); | ||
| } | ||
|
|
||
| throw e; |
There was a problem hiding this comment.
I guess it could respond with different errors, for example the height is not valid or something like that. In this case you nee to you other gRPC error codes.
added 3 commits
August 11, 2021 17:45
# Conflicts: # .github/workflows/.env # package-lock.json # package.json
shumkov
reviewed
Aug 13, 2021
| } catch (e) { | ||
| if (e instanceof RPCError) { | ||
| if (e.code === 32603) { | ||
| throw new InvalidHeightError(e.data, null, e.code); |
There was a problem hiding this comment.
Actually you need to throw gRPC error with gRPC error code. Precondition Failed is the best candidate.
shumkov
approved these changes
Aug 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Need to implement getConsensusParams method to get current consensus params from tenderdash
What was done?
Implemented new getConsensusParams method
How Has This Been Tested?
With platform-test-suite
Breaking Changes
No
Checklist:
For repository code-owners and collaborators only